Re: [PATCH] kprobes for s390 architecture

Heiko Carstens
2006-06-26T08:10:03Z

> Here's what I came up with Friday before I jumped timezones back east:
>
> void smp_replace_instruction(void *info)
> {
> struct ins_replace_args *parms;
>
> parms = (struct ins_replace_args *) info;
> cmpxchg(parms->addr, parms->oinsn, parms->ninsn);
> }
>
> void __kprobes arch_arm_kprobe(struct kprobe *p)
> {
> struct ins_replace_args parms;
> parms.addr = p->addr;
> parms.ninsn = BREAKPOINT_INSTRUCTION;
> parms.oinsn = p->opcode;
>
> on_each_cpu(smp_replace_instruction, &parms, 0, 1);
> } etc...
>
> After reading your notes it's probably overkill doing the cs on each cpu, since
> the interrupt will discard the prefetched instructions.

Indeed. Another thing that should not be forgotten: it could be that the
whole kernel text segment resides in a shared read only segment. So it can
be shared by multiple z/VM guests.
In that case the cs instruction will fail. Looks like you need to write the
part that replaces the instruction in assembly and supply a fixup section
which in turn makes sure that -EFAULT is returned.