From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932101AbWGKTnq@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932101AbWGKTnq (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 11 Jul 2006 15:43:46 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932102AbWGKTnq
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 11 Jul 2006 15:43:46 -0400
Received: from fmr18.intel.com ([134.134.136.17]:5593 "EHLO
	orsfmr003.jf.intel.com") by vger.kernel.org with ESMTP
	id S932101AbWGKTnp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Jul 2006 15:43:45 -0400
Subject: Re: [PATCH] irqtrace-option-off-compile-fix
From: Tim Chen <tim.c.chen@linux.intel.com>
Reply-To: tim.c.chen@linux.intel.com
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, akpm@osdl.org
In-Reply-To: <1152641141.3128.104.camel@laptopd505.fenrus.org>
References: <1152577120.7654.9.camel@localhost.localdomain>
	 <1152601989.3128.10.camel@laptopd505.fenrus.org>
	 <1152635003.7654.40.camel@localhost.localdomain>
	 <1152637993.3128.96.camel@laptopd505.fenrus.org>
	 <1152635804.7654.44.camel@localhost.localdomain>
	 <1152641141.3128.104.camel@laptopd505.fenrus.org>
Content-Type: text/plain
Organization: Intel
Date: Tue, 11 Jul 2006 12:02:20 -0700
Message-Id: <1152644540.3578.1.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.2 (2.0.2-8) 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2006-07-11 at 20:05 +0200, Arjan van de Ven wrote: 
> On Tue, 2006-07-11 at 09:36 -0700, Tim Chen wrote:
> > On Tue, 2006-07-11 at 19:13 +0200, Arjan van de Ven wrote:
> > > On Tue, 2006-07-11 at 09:23 -0700, Tim Chen wrote:
> > > > I was testing on x86_64 and turned off the option in
> > > > arch/x86_64/Kconfig.debug. 
> > > > 
> > > > When the option is turned off, the following functions become undefined:
> > > > local_irq_disable()           
> > > > local_irq_enable()             
> > > > local_irq_save(flags)          
> > > > local_irq_restore(flags)       
> > > > safe_halt() 
> > > > local_save_flags()
> > > > irqs_disabled()
> > > > irqs_disabled_flags(flags)                   
> > > > 
> > > > It seems plausible that some users may want to avoid the overhead of
> > > > tracing IRQFLAGS by turning the option off.
> > > 
> > > eh that is a different config option!
> > 
> > My typo, it is TRACE_IRQFLAGS_SUPPORT in arch/x86_64/Kconfig.debug.
> 
> 
> that should never ever be user setable. That just says if you have
> support for the api.
> 
> The one you want is CONFIG_TRACE_IRQFLAGS .. which is the one that
> actually turns the tracing on
> 

I could not turn off CONFIG_TRACE_IRQFLAGS_SUPPORT in .config directly. 
The command "scripts/kconfig/conf -s arch/x86_64/Kconfig" in Makefile
overwrites changes made to CONFIG_TRACE_IRQFLAGS_SUPPORT in .config
file.  So this is always turned on in .config if the option
TRACE_IRQFLAGS_SUPPORT is set in arch/x86_64/Kconfig.debug.  I may be
missing something.  Any suggestions?