public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PATCH] W1 patches for 2.6.18-rc1
@ 2006-07-12 23:22 Greg KH
  2006-07-12 23:24 ` [PATCH 1/3] [PATCH] W1: remove w1 mail list from lm_sensors Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-07-12 23:22 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel, Evgeniy Polyakov

Here are some tiny w1 patches that have been in the -mm tree for a
while.  They fix a bug, remove an unneeded .h file, and update the
	MAINTAINERS file.

Please pull from:
	git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/w1-2.6.git/
or from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/w1-2.6.git/
if it isn't synced up yet.

The full patch series will sent to the linux-kernel mailing list, if
anyone wants to see them.

thanks,

greg k-h


 MAINTAINERS                 |    1 -
 drivers/w1/masters/ds2482.c |    2 +-
 drivers/w1/w1_io.h          |   36 ------------------------------------
 3 files changed, 1 insertions(+), 38 deletions(-)
 delete mode 100644 drivers/w1/w1_io.h

---------------

Adrian Bunk:
      w1: remove drivers/w1/w1.h

Ben Gardner:
      w1: fix idle check loop in ds2482

Evgeniy Polyakov:
      W1: remove w1 mail list from lm_sensors.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] [PATCH] W1: remove w1 mail list from lm_sensors.
  2006-07-12 23:22 [GIT PATCH] W1 patches for 2.6.18-rc1 Greg KH
@ 2006-07-12 23:24 ` Greg KH
  2006-07-12 23:24   ` [PATCH 2/3] [PATCH] w1: fix idle check loop in ds2482 Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-07-12 23:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Evgeniy Polyakov, Greg Kroah-Hartman

From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>

lm_sensors mail list is going to be splitted into separate subdev lists,
so remove w1 from there.

http://lists.lm-sensors.org/pipermail/lm-sensors/2006-June/016507.html

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 MAINTAINERS |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 645a9f8..491e034 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3180,7 +3180,6 @@ S:	Maintained
 W1 DALLAS'S 1-WIRE BUS
 P:	Evgeniy Polyakov
 M:	johnpol@2ka.mipt.ru
-L:	lm-sensors@lm-sensors.org
 S:	Maintained
 
 W83L51xD SD/MMC CARD INTERFACE DRIVER
-- 
1.4.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] [PATCH] w1: fix idle check loop in ds2482
  2006-07-12 23:24 ` [PATCH 1/3] [PATCH] W1: remove w1 mail list from lm_sensors Greg KH
@ 2006-07-12 23:24   ` Greg KH
  2006-07-12 23:24     ` [PATCH 3/3] [PATCH] w1: remove drivers/w1/w1.h Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-07-12 23:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ben Gardner, Evgeniy Polyakov, Greg Kroah-Hartman

From: Ben Gardner <gardner.ben@gmail.com>

The idle check loop has a greater-than where it should have a less-than.
This causes the ds2482 driver to check for the idle condition exactly
once, which causes it to fail on faster machines.

Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/w1/masters/ds2482.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
index af492cc..d93eb62 100644
--- a/drivers/w1/masters/ds2482.c
+++ b/drivers/w1/masters/ds2482.c
@@ -218,7 +218,7 @@ static int ds2482_wait_1wire_idle(struct
 		do {
 			temp = i2c_smbus_read_byte(&pdev->client);
 		} while ((temp >= 0) && (temp & DS2482_REG_STS_1WB) &&
-			 (++retries > DS2482_WAIT_IDLE_TIMEOUT));
+			 (++retries < DS2482_WAIT_IDLE_TIMEOUT));
 	}
 
 	if (retries > DS2482_WAIT_IDLE_TIMEOUT)
-- 
1.4.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] [PATCH] w1: remove drivers/w1/w1.h
  2006-07-12 23:24   ` [PATCH 2/3] [PATCH] w1: fix idle check loop in ds2482 Greg KH
@ 2006-07-12 23:24     ` Greg KH
  2006-07-13  0:25       ` Nish Aravamudan
  0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2006-07-12 23:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Adrian Bunk, Evgeniy Polyakov, Greg Kroah-Hartman

From: Adrian Bunk <bunk@stusta.de>

drivers/w1/w1_io.h is both a subset of drivers/w1/w1.h and no longer
#include'd by any file.

This patch therefore removes w1_io.h.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/w1/w1_io.h |   36 ------------------------------------
 1 files changed, 0 insertions(+), 36 deletions(-)

diff --git a/drivers/w1/w1_io.h b/drivers/w1/w1_io.h
deleted file mode 100644
index 9a76d2a..0000000
--- a/drivers/w1/w1_io.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/*
- *	w1_io.h
- *
- * Copyright (c) 2004 Evgeniy Polyakov <johnpol@2ka.mipt.ru>
- *
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- */
-
-#ifndef __W1_IO_H
-#define __W1_IO_H
-
-#include "w1.h"
-
-u8 w1_triplet(struct w1_master *dev, int bdir);
-void w1_write_8(struct w1_master *, u8);
-int w1_reset_bus(struct w1_master *);
-u8 w1_calc_crc8(u8 *, int);
-void w1_write_block(struct w1_master *, const u8 *, int);
-u8 w1_read_block(struct w1_master *, u8 *, int);
-void w1_search_devices(struct w1_master *dev, w1_slave_found_callback cb);
-int w1_reset_select_slave(struct w1_slave *sl);
-
-#endif /* __W1_IO_H */
-- 
1.4.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 3/3] [PATCH] w1: remove drivers/w1/w1.h
  2006-07-12 23:24     ` [PATCH 3/3] [PATCH] w1: remove drivers/w1/w1.h Greg KH
@ 2006-07-13  0:25       ` Nish Aravamudan
  0 siblings, 0 replies; 5+ messages in thread
From: Nish Aravamudan @ 2006-07-13  0:25 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, Adrian Bunk, Evgeniy Polyakov, Greg Kroah-Hartman

On 7/12/06, Greg KH <greg@kroah.com> wrote:
> From: Adrian Bunk <bunk@stusta.de>
>
> drivers/w1/w1_io.h is both a subset of drivers/w1/w1.h and no longer
> #include'd by any file.
>
> This patch therefore removes w1_io.h.

Minor nit, that's not what the subject says.

Thanks,
Nish

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-07-13  0:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-12 23:22 [GIT PATCH] W1 patches for 2.6.18-rc1 Greg KH
2006-07-12 23:24 ` [PATCH 1/3] [PATCH] W1: remove w1 mail list from lm_sensors Greg KH
2006-07-12 23:24   ` [PATCH 2/3] [PATCH] w1: fix idle check loop in ds2482 Greg KH
2006-07-12 23:24     ` [PATCH 3/3] [PATCH] w1: remove drivers/w1/w1.h Greg KH
2006-07-13  0:25       ` Nish Aravamudan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox