Re: [RFC][PATCH 3/6] SLIM main patch

Kylene Jo Hall
2006-07-14T18:06:37Z

Thanks it will be fixed in the next revision.

On Fri, 2006-07-14 at 10:44 -0700, Dave Hansen wrote:
> On Fri, 2006-07-14 at 10:24 -0700, Kylene Jo Hall wrote:
> > +static void revoke_mmap_wperm(struct slm_file_xattr *cur_level)
> > +{
> > + struct vm_area_struct *mpnt;
> > + struct file *file;
> > + struct dentry *dentry;
> > + struct slm_isec_data *isec;
> > +
> > + flush_cache_mm(current->mm);
> > +
> > + for (mpnt = current->mm->mmap; mpnt; mpnt = mpnt->vm_next) {
> > + file = mpnt->vm_file;
> > + if (!file)
> > + continue;
>
> You need to hold the mmap_sem for read while walking this list.
>
> -- Dave
>