Re: Bad ext3/nfs DoS bug

Neil Brown
2006-07-26T23:54:12Z

On Wednesday July 26, sandeen@sandeen.net wrote:
> > +EXPORT_SYMBOL_GPL(export_iget);
> ...
> > +static struct dentry *ext3_get_dentry(struct super_block *sb, void *vobjp)
> > +{
> > + __u32 *objp = vobjp;
> > + unsigned long ino = objp[0];
> > + __u32 generation = objp[1];
> > +
> > + if (ino != EXT3_ROOT_INO && ino < EXT3_FIRST_INO(sb))
> > + return ERR_PTR(-ESTALE);
> > +
> > + return export_iget(sb, ino, generation);
> > +}
>
> Hm, with this, ext3.ko has a new dependency on exportfs.ko. Is that
> desirable/acceptable?

Drat, you're right.
No, I don't think that is what we want.
I'll do it differently in a day or so.

Thanks,
NeilBrown