From: Panagiotis Issaris <takis@gna.org>
To: "Daniel K." <daniel@cluded.net>
Cc: Panagiotis Issaris <takis@lumumba.uhasselt.be>,
linux-kernel@vger.kernel.org, linux-eata@i-connect.net
Subject: Re: [PATCH 2/2] Forgotten memset
Date: Thu, 20 Jul 2006 19:21:03 +0200 [thread overview]
Message-ID: <1153416063.11873.15.camel@hemera> (raw)
In-Reply-To: <44BD8FB7.9080307@cluded.net>
Hi,
On wo, 2006-07-19 at 01:49 +0000, Daniel K. wrote:
> Panagiotis Issaris wrote:
> > --- a/drivers/scsi/ide-scsi.c
> > +++ b/drivers/scsi/ide-scsi.c
> > @@ -327,7 +327,7 @@ static int idescsi_check_condition(ide_d
> >
> > /* stuff a sense request in front of our current request */
> > pc = kzalloc (sizeof (idescsi_pc_t), GFP_ATOMIC);
> > - rq = kmalloc (sizeof (struct request), GFP_ATOMIC);
> > + rq = kzalloc (sizeof (struct request), GFP_ATOMIC);
> > buf = kzalloc(SCSI_SENSE_BUFFERSIZE, GFP_ATOMIC);
> > if (pc == NULL || rq == NULL || buf == NULL) {
> > kfree(buf);
> >
> > Was this forgotten and therefore, is it necessary or useful to zero this
> > out?
>
> No, this code snippet is followed by a call to
>
> ide_init_drive_cmd(rq)
>
> which calls memset()
Ouch. I should have seen that. Thanks!
With friendly regards,
Takis
prev parent reply other threads:[~2006-07-20 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 1:34 [PATCH 2/2] Forgotten memset Panagiotis Issaris
2006-07-19 1:49 ` Daniel K.
2006-07-20 17:21 ` Panagiotis Issaris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153416063.11873.15.camel@hemera \
--to=takis@gna.org \
--cc=daniel@cluded.net \
--cc=linux-eata@i-connect.net \
--cc=linux-kernel@vger.kernel.org \
--cc=takis@lumumba.uhasselt.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox