From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: David Schwartz <davids@webmaster.com>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 6/6] cpuid neatening.
Date: Sun, 23 Jul 2006 01:22:45 +1000 [thread overview]
Message-ID: <1153581765.15632.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20060722000328.cd9e7e0e.akpm@osdl.org>
> > +static inline void __cpuid(unsigned int *eax, unsigned int *ebx,
> > + unsigned int *ecx, unsigned int *edx)
> > +{
> > + /* ecx is often an input as well as an output. */
> > + __asm__("cpuid"
> > + : "=a" (*eax),
> > + "=b" (*ebx),
> > + "=c" (*ecx),
> > + "=d" (*edx)
> > + : "0" (*eax), "2" (*ecx));
> > +}
> > +
>
> Shouldn't that be:
>
> __asm__("cpuid"
> : "+a" (*eax),
> "=b" (*ebx),
> "+c" (*ecx),
> "=d" (*edx)
> );
Perhaps? I copied the existing code...
Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
next parent reply other threads:[~2006-07-22 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060722000328.cd9e7e0e.akpm@osdl.org>
2006-07-22 15:22 ` Rusty Russell [this message]
[not found] <1153526643.13699.18.camel@localhost.localdomain>
[not found] ` <1153526798.13699.23.camel@localhost.localdomain>
2006-07-22 0:13 ` [PATCH 6/6] cpuid neatening Rusty Russell
2006-07-22 4:12 ` David Schwartz
2006-07-24 23:58 ` H. Peter Anvin
2006-07-25 1:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153581765.15632.1.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=davids@webmaster.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox