public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: hch <hch@infradead.org>
Cc: Ed Lin <ed.lin@promise.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"James.Bottomley" <James.Bottomley@SteelEye.com>,
	linux-kernel <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
	promise_linux <promise_linux@promise.com>, jeff <jeff@garzik.org>
Subject: Re: [PATCH] Promise 'stex' driver
Date: Wed, 26 Jul 2006 02:20:06 +0100	[thread overview]
Message-ID: <1153876807.7559.39.camel@localhost> (raw)
In-Reply-To: <20060725092656.GA28195@infradead.org>

On Maw, 2006-07-25 at 10:26 +0100, hch wrote:
> We have more than enough precedence for poking the bridge that comes as
> part of addon cards.  As long as the code makes sure it never pokes a bridge
> of the same type that is not on the card (and I don't have the code in front
> of me right now to check whether it's true) we can keep this code.  Please
> make sure to add a big comment that explains what is going on in detail
> and why it's okay in this special case.

It does check the basic layout so looks robust. Checking subvendor stuff
is normally a good back-up. We do similar plumbing work in the Promise
IDE and I2O code to handle the old SuperTrak/SX6000 cards and it work
solidly.

Alan


  reply	other threads:[~2006-07-26  0:19 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <NONAMEBFJ3sl3xbYiMC000000d4@nonameb.ptu.promise.com>
2006-07-25  9:26 ` [PATCH] Promise 'stex' driver hch
2006-07-26  1:20   ` Alan Cox [this message]
2006-07-25 17:30 ` Jeff Garzik
2006-07-19 15:07 Ed Lin
2006-07-20 21:27 ` Jeff Garzik
2006-07-20 23:55   ` James Bottomley
2006-07-21  0:16     ` Jeff Garzik
2006-07-21  1:07       ` Jens Axboe
2006-07-21  1:25         ` Jeff Garzik
2006-07-21  1:38           ` Jens Axboe
2006-07-21  2:10             ` Jeff Garzik
2006-07-21  2:36               ` Jens Axboe
2006-07-21  3:01                 ` Jeff Garzik
2006-07-21  3:18                   ` Jens Axboe
2006-07-21  3:52                     ` Jeff Garzik
2006-07-21 12:13                       ` Jens Axboe
2006-07-23 19:45                   ` hch
2006-07-23 20:21                     ` Jeff Garzik
2006-07-23 19:44                 ` hch
2006-07-21  1:06   ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2006-06-10 16:08 Jeff Garzik
2006-06-10 16:10 ` Christoph Hellwig
2006-06-10 16:29   ` James Bottomley
2006-06-10 16:34     ` Christoph Hellwig
2006-06-10 16:50       ` Jeff Garzik
2006-06-10 17:10         ` Christoph Hellwig
2006-06-10 16:30   ` Jeff Garzik
2006-06-10 17:06 ` Christoph Hellwig
2006-06-10 17:37   ` Jeff Garzik
2006-06-10 18:22     ` James Bottomley
2006-06-10 18:43       ` Jeff Garzik
2006-06-10 22:28   ` Jeff Garzik
2006-06-10 17:47 ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1153876807.7559.39.camel@localhost \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=James.Bottomley@SteelEye.com \
    --cc=akpm@osdl.org \
    --cc=ed.lin@promise.com \
    --cc=hch@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=promise_linux@promise.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox