From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030293AbWGZATB (ORCPT ); Tue, 25 Jul 2006 20:19:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030291AbWGZATB (ORCPT ); Tue, 25 Jul 2006 20:19:01 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:29831 "EHLO out.lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1030294AbWGZAS7 (ORCPT ); Tue, 25 Jul 2006 20:18:59 -0400 Subject: Re: [PATCH] Promise 'stex' driver From: Alan Cox To: hch Cc: Ed Lin , linux-scsi , "James.Bottomley" , linux-kernel , akpm , promise_linux , jeff In-Reply-To: <20060725092656.GA28195@infradead.org> References: <20060725092656.GA28195@infradead.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 26 Jul 2006 02:20:06 +0100 Message-Id: <1153876807.7559.39.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Maw, 2006-07-25 at 10:26 +0100, hch wrote: > We have more than enough precedence for poking the bridge that comes as > part of addon cards. As long as the code makes sure it never pokes a bridge > of the same type that is not on the card (and I don't have the code in front > of me right now to check whether it's true) we can keep this code. Please > make sure to add a big comment that explains what is going on in detail > and why it's okay in this special case. It does check the basic layout so looks robust. Checking subvendor stuff is normally a good back-up. We do similar plumbing work in the Promise IDE and I2O code to handle the old SuperTrak/SX6000 cards and it work solidly. Alan