Re: [PATCH] Promise 'stex' driver

Christoph Hellwig
2006-06-10T16:34:23Z

On Sat, Jun 10, 2006 at 11:29:12AM -0500, James Bottomley wrote:
> On Sat, 2006-06-10 at 17:10 +0100, Christoph Hellwig wrote:
> > The driver is not for scsi hardware. Please implement it as block
> > driver.
>
> Actually, I'm afraid it is ... look at the mailbox path ... it's one of
> these increasingly prevalent raid HBAs that speaks SCSI at the firmware
> level. Most commands are direct passthroughs, only INQUIRY and
> MODE_SENSE are actually emulated in the driver.

Oops, you're right. It emulates READ/WRITE6 at the top of the queuecommand
routine which made me thing it'll emulate more below.

So removing the READ/WRITE6 emulation and setting the flag so the midlayer
only uses READ/WRITE10+ is on top of the TODO list. Right after that is
using the scsi_kmap_atomic_sg/scsi_kunmap_atomic_sg for the remaining
emulated commands. More comments later.