Re: [discuss] [Patch] 2/5 in support of hot-add memory x86_64 create arch_find_node

[keith mannthey <kmannth@us.ibm.com>]

On Sat, 2006-07-29 at 18:25 +0200, Andi Kleen wrote:
> On Saturday 29 July 2006 04:52, keith mannthey wrote:
> >   With the advent of the new ACPI hot-plug memory driver and mechanism
> > is needed to deal with ACPI add memory events that do not contain the
> > pxm (node) information. I do not believe that the add-event is required
> > to contain this information so I create a arch_find_node generic layer
> > used in the generic add_memory function.
> >
> >   If add_memory is called with node < 0 arch_find_node is invoked to
> > fine the correct node to add the memory. This created the generic
> > construct of arch_find_node.
> 
> It would be cleaner to always call add_memory from architecture specific
> code instead of such ugly hooks

Since 2.6.18 it goes

acpi (generic calling add_memory)
add_memory (generic)
arch_add_memory (x86_64)
__add_pages (generic)

The generic add_memory call is good as it does the dynamic pgdat
allocation for new nodes.  The generic add_memory call need the correct
node infomation.  

Do you think we should do 

acpi (generic calling add_memory)
arch_pre_add_memory? (x86_64)
add_memory (generic)
arch_add_memory (x86_64)
__add_pages (generic)

? 
It would just create a function hook. 

Thanks, 
  Keith