Re: [RFC 1/4] kevent: core files.

Pekka Enberg
2006-07-09T14:59:44Z

On 7/9/06, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
> +struct kevent *kevent_alloc(gfp_t mask)
> +{
> + struct kevent *k;
> +
> + if (kevent_cache)
> + k = kmem_cache_alloc(kevent_cache, mask);
> + else
> + k = kzalloc(sizeof(struct kevent), mask);
> +
> + return k;
> +}

What's this for? Why would kevent_cache be NULL? Note that you can use
kmem_cache_zalloc() for fixed size allocations that need to be zeroed.

On 7/9/06, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
> +
> +void kevent_free(struct kevent *k)
> +{
> + memset(k, 0xab, sizeof(struct kevent));

Why is slab poisoning not sufficient?

> + if (kevent_cache)
> + kmem_cache_free(kevent_cache, k);
> + else
> + kfree(k);
> +}