Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.

Evgeniy Polyakov
2006-08-16T13:41:18Z

On Wed, Aug 16, 2006 at 02:30:14PM +0100, Christoph Hellwig (hch@infradead.org) wrote:
> On Mon, Aug 14, 2006 at 10:21:36AM +0400, Evgeniy Polyakov wrote:
> >
> > poll/select() notifications. Timer notifications.
> >
> > This patch includes generic poll/select and timer notifications.
> >
> > kevent_poll works simialr to epoll and has the same issues (callback
> > is invoked not from internal state machine of the caller, but through
> > process awake).
>
> I'm not a big fan of duplicating code over and over. kevent is a candidate
> for a generic event devlivery mechanisms which is a _very_ good thing. But
> starting that system by duplicating existing functionality is not very nice.
>
> What speaks against a patch the recplaces the epoll core by something that
> build on kevent while still supporting the epoll interface as a compatibility
> shim?

There is no problem from my side, but epoll and kevent_poll differs on
some aspects, so it can be better to not replace them for a while.

> > Timer notifications can be used for fine grained per-process time
> > management, since interval timers are very inconvenient to use,
> > and they are limited.
>
> I have similar reservations about this one. Having timers as part of a
> generic events system is very nice, but having so much duplicated functionality
> is not. Cc'ed Thomas on behalf of the Timer cabal if there's a point in
> integrating this into a larger framework of timer code.
>
>
> Also it would be nice if you could submit each of the notifications as a patch
> on it's own.

Ok.

--
Evgeniy Polyakov