Re: [take4 1/4] kevent: Core files.

Evgeniy Polyakov
2006-08-05T18:11:17Z

On Sat, Aug 05, 2006 at 10:57:02AM -0700, GregKH (greg@kroah.com) wrote:
> > + dev = class_device_create(kevent_user_class, NULL,
> > + MKDEV(kevent_user_major, 0), NULL, kevent_name);
> > + if (IS_ERR(dev)) {
> > + printk(KERN_ERR "Failed to create %d.%d class device in \"%s\" class: err=%ld.\n",
> > + kevent_user_major, 0, kevent_name, PTR_ERR(dev));
> > + err = PTR_ERR(dev);
> > + goto err_out_class_destroy;
> > + }
>
> As you are only using 1 minor number in this code, why not just use a
> miscdevice instead? It saves a bit of overhead and makes the code a
> tiny bit smaller :)

No problem. I will move it to miscdevice instead of full chardev.

> thanks,
>
> greg k-h

--
Evgeniy Polyakov