From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andi Kleen <ak@suse.de>
Cc: torvalds@osdl.org, discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk
Date: Sat, 29 Jul 2006 17:14:28 -0400 [thread overview]
Message-ID: <1154207668.5784.35.camel@localhost> (raw)
In-Reply-To: <44cbba3f.mPUieUe31/EOZ6FZ%ak@suse.de>
On Sat, 2006-07-29 at 21:42 +0200, Andi Kleen wrote:
> For some reason it triggers always with NFS root and spams the kernel
> logs of my nfs root boxes a lot.
>
> Cc: trond.myklebust@fys.uio.no
> Signed-off-by: Andi Kleen <ak@suse.de>
Big ACK! I never really understood why we needed this printk, and yes,
it does spam the syslog heavily on all NFS clients...
Cheers,
Trond
> ---
> mm/filemap.c | 2 --
> 1 files changed, 2 deletions(-)
>
> Index: linux-2.6.18-rc2-git7/mm/filemap.c
> ===================================================================
> --- linux-2.6.18-rc2-git7.orig/mm/filemap.c
> +++ linux-2.6.18-rc2-git7/mm/filemap.c
> @@ -849,8 +849,6 @@ static void shrink_readahead_size_eio(st
> return;
>
> ra->ra_pages /= 4;
> - printk(KERN_WARNING "Reducing readahead size to %luK\n",
> - ra->ra_pages << (PAGE_CACHE_SHIFT - 10));
> }
>
> /**
next prev parent reply other threads:[~2006-07-29 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-29 19:42 [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk Andi Kleen
2006-07-29 21:14 ` Trond Myklebust [this message]
2006-07-30 1:04 ` Nate Diller
2006-07-30 4:22 ` Trond Myklebust
2006-07-30 6:26 ` Andrew Morton
2006-07-30 16:12 ` Trond Myklebust
2006-07-30 16:48 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154207668.5784.35.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox