Re: [PATCH for 2.6.18] [8/8] MM: Remove rogue readahead printk

Trond Myklebust
2006-07-29T21:14:43Z

On Sat, 2006-07-29 at 21:42 +0200, Andi Kleen wrote:
> For some reason it triggers always with NFS root and spams the kernel
> logs of my nfs root boxes a lot.
>
> Cc: trond.myklebust@fys.uio.no
> Signed-off-by: Andi Kleen <ak@suse.de>

Big ACK! I never really understood why we needed this printk, and yes,
it does spam the syslog heavily on all NFS clients...

Cheers,
Trond

> ---
> mm/filemap.c | 2 --
> 1 files changed, 2 deletions(-)
>
> Index: linux-2.6.18-rc2-git7/mm/filemap.c
> ===================================================================
> --- linux-2.6.18-rc2-git7.orig/mm/filemap.c
> +++ linux-2.6.18-rc2-git7/mm/filemap.c
> @@ -849,8 +849,6 @@ static void shrink_readahead_size_eio(st
> return;
>
> ra->ra_pages /= 4;
> - printk(KERN_WARNING "Reducing readahead size to %luK\n",
> - ra->ra_pages << (PAGE_CACHE_SHIFT - 10));
> }
>
> /**