public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>
To: Andi Kleen <ak@suse.de>
Cc: torvalds@osdl.org, discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for 2.6.18] [2/8] x86_64: On Intel systems when CPU has C3 don't use TSC
Date: Tue, 01 Aug 2006 14:04:43 +0100	[thread overview]
Message-ID: <1154437483.3264.14.camel@localhost.localdomain> (raw)
In-Reply-To: <44cbba2d.ejpOKfo7QfGElmoT%ak@suse.de>

On Sat, 2006-07-29 at 21:42 +0200, Andi Kleen wrote:
> On Intel systems generally the TSC stops in C3 or deeper, 
> so don't use it there. Follows similar logic on i386.
> 
> This should fix problems on Meroms.
> 
> Signed-off-by: Andi Kleen <ak@suse.de>
> 
...
> +	/* Most intel systems have synchronized TSCs except for
> +	   multi node systems */
> + 	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) {
> +#ifdef CONFIG_ACPI
> +		/* But TSC doesn't tick in C3 so don't use it there */
> +		if (acpi_fadt.length > 0 && acpi_fadt.plvl3_lat < 100)
> +			return 1;
> +#endif
> + 		return 0;
> +	}
> +
>   	/* Assume multi socket systems are not synchronized */
>   	return num_present_cpus() > 1;
>  }

Hi, 

I had some faith in this patch , but this just enable boot parameter
notsc (which I already use). And "just" disable tsc don't solve all the
problems. 

After "Using ACPI (MADT) for SMP configuration information"
my acpi_fadt.length is great than  0
acpi_fadt.plvl3_lat is 1001

On BIOS 1.40 update description of ASRock, claims this VIA chipset have
C1 stepping support.

this is a Pentium Dual Core on a 775Dual-880Pro
http://www.asrock.com/product/775Dual-880Pro.htm
http://bugme.osdl.org/show_bug.cgi?id=6419

Thanks,
Sérgio M. B.


  reply	other threads:[~2006-08-01 13:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29 19:42 [PATCH for 2.6.18] [2/8] x86_64: On Intel systems when CPU has C3 don't use TSC Andi Kleen
2006-08-01 13:04 ` Sergio Monteiro Basto [this message]
2006-08-01 17:10   ` [discuss] " Andi Kleen
2006-08-01 21:40     ` Sergio Monteiro Basto
2006-08-01 21:56       ` Andi Kleen
     [not found]         ` <1154470000.5123.1.camel@localhost.portugal>
2006-08-01 22:21           ` Andi Kleen
2006-08-01 22:52             ` Sergio Monteiro Basto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154437483.3264.14.camel@localhost.localdomain \
    --to=sergio@sergiomb.no-ip.org \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox