From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@redhat.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, jbaron@redhat.com
Subject: Re: frequent slab corruption (since a long time)
Date: Thu, 03 Aug 2006 00:14:21 +0100 [thread overview]
Message-ID: <1154560462.23655.43.camel@localhost.localdomain> (raw)
In-Reply-To: <20060802222321.GH3639@redhat.com>
Ar Mer, 2006-08-02 am 18:23 -0400, ysgrifennodd Dave Jones:
> None of the code manipulating tty->count seems to be under
> the tty_mutex. Should it be ?
> Or is this protected through some other means?
Its old lock_kernel() code so its a prime suspect for most offences.
Given the age of the reports it appears that the tty buffering changes
are too new. The ldisc locking changes are a candidate but shouldn't be
doing anything that breaks the kernel lock stuff. Will look tomorrow see
if anything strikes me about that lot.
The tty_mutex primarily protected current->signal.tty (except if you are
using SELinux which has some extremely dubious looking code for tty
handling). Someone ought to review flush_unauthorized_files() although
it doesn't fit this problem.
Alan
prev parent reply other threads:[~2006-08-02 22:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 2:16 frequent slab corruption (since a long time) Dave Jones
2006-08-02 2:34 ` Roland Dreier
2006-08-02 3:37 ` Andi Kleen
2006-08-02 4:22 ` Dave Jones
2006-08-02 4:35 ` Andi Kleen
2006-08-02 4:46 ` Dave Jones
2006-08-02 5:05 ` David Miller
2006-08-02 5:31 ` David Miller
2006-08-02 22:23 ` Dave Jones
2006-08-02 22:49 ` David Miller
2006-08-03 17:40 ` Alan Cox
2006-08-03 17:56 ` Dave Jones
2006-08-03 20:48 ` Alan Cox
2006-08-02 23:14 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154560462.23655.43.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox