From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dirk Eibach <eibach@gdsys.de>
Cc: rmk+serial@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: add ioctl for setting the throttle threshold (handshake)
Date: Thu, 03 Aug 2006 14:25:00 +0100 [thread overview]
Message-ID: <1154611500.23655.75.camel@localhost.localdomain> (raw)
In-Reply-To: <44D1F1C5.6040809@gdsys.de>
Ar Iau, 2006-08-03 am 14:53 +0200, ysgrifennodd Dirk Eibach:
> To be more flexible ioctls were added to control the throttling thresholds.
>
> This patch applies to kernel 2.6.16.
>
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
NAK
Two reasons
#1 Users should not be expected to set these kind of parameters, the
kernel should just get it right
#2 With the new buffering if you respond too slowly then thats allowed
for (with a limit enforced in the patch I posted)
Those two alone aren't quite enough to deal with some corner cases where
you throttle too late and queue an oversized buffer. The changes in
2.6.18-rc by Paul however ensure that such a buffer is fed into the
ldisc in appropriate sized chunks to avoid data loss.
Alan
prev parent reply other threads:[~2006-08-03 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 12:53 [PATCH] tty: add ioctl for setting the throttle threshold (handshake) Dirk Eibach
2006-08-03 13:25 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154611500.23655.75.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=eibach@gdsys.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox