From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: don't taint UP K7's running SMP kernels.
Date: Thu, 03 Aug 2006 22:04:32 +0100 [thread overview]
Message-ID: <1154639072.23655.122.camel@localhost.localdomain> (raw)
In-Reply-To: <20060803183224.GA10797@redhat.com>
Ar Iau, 2006-08-03 am 14:32 -0400, ysgrifennodd Dave Jones:
> We have a test that looks for invalid pairings of certain athlon/durons
> that weren't designed for SMP, and taint accordingly (with 'S') if we find
> such a configuration. However, this test shouldn't fire if there's only
> a single CPU present. It's perfectly valid for an SMP kernel to boot on UP
> hardware for example.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/arch/i386/kernel/smpboot.c~ 2006-08-03 14:29:47.000000000 -0400
> +++ linux-2.6/arch/i386/kernel/smpboot.c 2006-08-03 14:30:43.000000000 -0400
> @@ -177,6 +177,9 @@ static void __devinit smp_store_cpu_info
> */
> if ((c->x86_vendor == X86_VENDOR_AMD) && (c->x86 == 6)) {
>
> + if (num_online_cpus() == 1)
> + goto valid_k7;
> +
> /* Athlon 660/661 is valid. */
> if ((c->x86_model==6) && ((c->x86_mask==0) || (c->x86_mask==1)))
> goto valid_k7;
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2006-08-03 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 18:32 don't taint UP K7's running SMP kernels Dave Jones
2006-08-03 21:04 ` Alan Cox [this message]
2006-08-04 0:53 ` Andi Kleen
2006-08-04 0:55 ` don't taint UP K7's running SMP kernels. II Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154639072.23655.122.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox