Re: [PATCH 1/4] x86 paravirt_ops: create no_paravirt.h for native ops

Rusty Russell
2006-08-07T06:03:40Z

On Sun, 2006-08-06 at 22:43 -0700, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> >> +/* Stop speculative execution */
> >> +static inline void sync_core(void)
> >> +{
> >> + unsigned int eax = 1, ebx, ecx, edx;
> >> + __cpuid(&eax, &ebx, &ecx, &edx);
> >> +}
> >>
> >
> > Actually I don't think this one should be para virtualized at all.
> > I don't see any reason at all why a hypervisor should trap it and it
> > is very time critical. I would recommend you move it back into the
> > normal files without hooks.

I don't see where it's time-critical...

Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law