Re: [PATCH 1/4] x86 paravirt_ops: create no_paravirt.h for native ops

Andi Kleen
2006-08-07T06:20:45Z

On Monday 07 August 2006 08:03, Rusty Russell wrote:
> On Sun, 2006-08-06 at 22:43 -0700, Jeremy Fitzhardinge wrote:
> > Andi Kleen wrote:
> > >> +/* Stop speculative execution */
> > >> +static inline void sync_core(void)
> > >> +{
> > >> + unsigned int eax = 1, ebx, ecx, edx;
> > >> + __cpuid(&eax, &ebx, &ecx, &edx);
> > >> +}
> > >>
> > >
> > > Actually I don't think this one should be para virtualized at all.
> > > I don't see any reason at all why a hypervisor should trap it and it
> > > is very time critical. I would recommend you move it back into the
> > > normal files without hooks.
>
> I don't see where it's time-critical...

See explanation in my other email. Also in general we want this one fast.

-Andi