Re: [take2 1/4] kevent: core files.

Evgeniy Polyakov
2006-08-01T13:56:06Z

On Tue, Aug 01, 2006 at 09:46:58AM -0400, James Morris (jmorris@namei.org) wrote:
> On Tue, 1 Aug 2006, Evgeniy Polyakov wrote:
>
> > + u->ready_num = 0;
> > +#ifdef CONFIG_KEVENT_USER_STAT
> > + u->wait_num = u->im_num = u->total = 0;
> > +#endif
>
> Generally, #ifdefs in the body of the kernel code are discouraged. Can
> you abstract these out as static inlines?

Yes, it is possible.
I would ask is it needed at all? It contains number of immediately fired
events (i.e. those which were ready when event was added and thus
syscall returned immediately showing that it is ready), total number of
events, which were inserted in the given queue and number of events
which were marked as ready after they were inserted.
Currently it is compilation option which ends up in printk with above
info when kevent queue is removed.

> - James
> --
> James Morris
> <jmorris@namei.org>

--
Evgeniy Polyakov