From: Ingo Molnar <mingo@redhat.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Roland Dreier <rdreier@cisco.com>,
openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix potential deadlock in mthca
Date: Mon, 14 Aug 2006 13:07:51 +0200 [thread overview]
Message-ID: <1155553671.22848.38.camel@earth> (raw)
In-Reply-To: <44DCAD34.5040502@linux.intel.com>
On Fri, 2006-08-11 at 09:15 -0700, Arjan van de Ven wrote:
> Roland Dreier wrote:
> > Here's a long-standing bug that lockdep found very nicely.
> >
> > Ingo/Arjan, can you confirm that the fix looks OK and I am using
> > spin_lock_nested() properly? I couldn't find much documentation or
> > many examples of it, so I'm not positive this is the right way to
> > handle this fix.
> >
>
> looks correct to me;
>
> Acked-by: Arjan van de Ven <arjan@linux.intel.com>
looks good to me too.
Acked-by: Ingo Molnar <mingo@elte.hu>
btw., we could introduce a new spin-lock op:
spin_lock_double(l1, l2);
...
spin_unlock_double(l1, l2);
because some other code, like kernel/sched.c, fs/dcache.c and
kernel/futex.c uses quite similar locking.
Ingo
prev parent reply other threads:[~2006-08-14 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 16:00 [PATCH] Fix potential deadlock in mthca Roland Dreier
2006-08-11 16:15 ` Arjan van de Ven
2006-08-14 11:07 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155553671.22848.38.camel@earth \
--to=mingo@redhat.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox