From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Eric Sesterhenn <snakebyte@gmx.de>, linux-kernel@vger.kernel.org
Subject: Re: [Patch] Fix signedness error in drivers/media/video/vivi.c
Date: Mon, 21 Aug 2006 12:10:51 -0300 [thread overview]
Message-ID: <1156173051.3580.36.camel@praia> (raw)
In-Reply-To: <1156098327.4051.36.camel@localhost.localdomain>
Em Dom, 2006-08-20 às 19:25 +0100, Alan Cox escreveu:
> Ar Sad, 2006-08-19 am 18:19 +0200, ysgrifennodd Eric Sesterhenn:
> > Since videobuf_reqbufs() returns negative values on errors the current
> > code does no real error checking since gcc removes the comparison.
> > This patch fixes this issue by making ret a normal, signed integer.
> >
> > Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
> >
>
> Doesn't apply to latest driver tree but the problem is still present.
Hmm... patch applied fine to v4l-dvb hg tree.
>
> Alan
>
Cheers,
Mauro.
prev parent reply other threads:[~2006-08-21 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 16:19 [Patch] Fix signedness error in drivers/media/video/vivi.c Eric Sesterhenn
2006-08-20 18:25 ` Alan Cox
2006-08-21 15:10 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156173051.3580.36.camel@praia \
--to=mchehab@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox