* [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4)
@ 2006-08-23 8:31 Zhou Yingchao
0 siblings, 0 replies; 3+ messages in thread
From: Zhou Yingchao @ 2006-08-23 8:31 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
An up() is called in kernel/stop_machine.c on failure, and also in
the caller unconditionally. I have reported, but now it is still
there.
--- kernel/stop_machine.c.orig 2006-08-23 14:53:36.000000000 +0800
+++ kernel/stop_machine.c 2006-08-23 14:53:55.000000000 +0800
@@ -111,7 +111,6 @@ static int stop_machine(void)
/* If some failed, kill them all. */
if (ret < 0) {
stopmachine_set_state(STOPMACHINE_EXIT);
- up(&stopmachine_mutex);
return ret;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4)
@ 2006-08-23 10:27 Zhou Yingchao
0 siblings, 0 replies; 3+ messages in thread
From: Zhou Yingchao @ 2006-08-23 10:27 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
An up() is called in kernel/stop_machine.c on failure, and also in
the caller unconditionally. I have reported, but now it is still here.
Signed-off-by: Zhou Yingchao <yingchao.zhou@gmail.com>
___
--- kernel/stop_machine.c.orig 2006-08-23 14:53:36.000000000 +0800
+++ kernel/stop_machine.c 2006-08-23 14:53:55.000000000 +0800
@@ -111,7 +111,6 @@ static int stop_machine(void)
/* If some failed, kill them all. */
if (ret < 0) {
stopmachine_set_state(STOPMACHINE_EXIT);
- up(&stopmachine_mutex);
return ret;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4)
@ 2006-08-23 10:45 Zhou Yingchao
0 siblings, 0 replies; 3+ messages in thread
From: Zhou Yingchao @ 2006-08-23 10:45 UTC (permalink / raw)
To: linux-kernel
An up() is called in kernel/stop_machine.c on failure, and also in
the caller unconditionally. I have reported, but now it is still here.
Signed-off-by: Zhou Yingchao <yingchao.zhou@gmail.com>
___
--- kernel/stop_machine.c.orig 2006-08-23 14:53:36.000000000 +0800
+++ kernel/stop_machine.c 2006-08-23 14:53:55.000000000 +0800
@@ -111,7 +111,6 @@ static int stop_machine(void)
/* If some failed, kill them all. */
if (ret < 0) {
stopmachine_set_state(STOPMACHINE_EXIT);
- up(&stopmachine_mutex);
return ret;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-08-23 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-23 10:45 [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4) Zhou Yingchao
-- strict thread matches above, loose matches on Subject: below --
2006-08-23 10:27 Zhou Yingchao
2006-08-23 8:31 Zhou Yingchao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox