Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread

Christoph Hellwig
2006-08-25T14:39:09Z

On Thu, Aug 24, 2006 at 04:22:42PM -0500, Serge E. Hallyn wrote:
> Update the s390 cooperative memory manager, which can be a module,
> to use kthread rather than kernel_thread, whose EXPORT is deprecated.
>
> This patch compiles and boots fine, but I don't know how to really
> test the driver.

NACK. Please do a real conversion to the kthread paradigm instead of
doctoring around the trivial bits that could be changed with a script.

Please use kthread_should_stop() and remove the cmm_thread_wait
waitqueue in favour of wake_up_process. The timer useage could
probably be replaced with smart usage of schedule_timeout().
Also the code seems to miss a proper thread termination on module
removal.