public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: linux@horizon.com, linux-kernel@vger.kernel.org, theotso@us.ibm.com
Subject: Re: Linux time code
Date: Mon, 28 Aug 2006 15:36:49 -0700	[thread overview]
Message-ID: <1156804609.16398.17.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0608281250060.6761@scrub.home>

On Mon, 2006-08-28 at 13:39 +0200, Roman Zippel wrote:
> On Thu, 23 Aug 2006, linux@horizon.com wrote:
> > > Additionally creating UTS and UTC at the same time would be a bit
> > > complicated. Your solution above isn't quite UTS, since it only handles
> > > the leap insertion, however the insertion case is the one that causes
> > > users most of the pain (since the clock goes backward), so it may very
> > > well be good enough.
> > 
> > It's not that it's hard to implement leap deletion, but it's code
> > on a moderately hot path (gettimeofday() is a very popular system
> > call) that will, as far as anyone knows, never be used.
> > 
> > If you want the full version, try:
> > 
> > 	case CLOCK_UTS:
> > 		/* Recommended for gettimeofday() & time() */
> > 		/* See http://www.cl.cam.ac.uk/~mgk25/uts.txt */
> > 		clock_gettime(CLOCK_TAI, tp);
> > 		tp->tv_sec -= tai_minus_utc;
> > 
> > 		if (tp->tv_sec > next_leap_second) {
> > 			tp->tv_sec += (next_leap_second & 1) ? -1 : 1;
> > 
> > 		} else if (next_leap_second - tp->tv_sec < 1000) {
> > 			/* 1000 UTC/TAI seconds = 999 or 1001 UTS seconds */
> > 			uint32_t offset = next_leap_second - tp->tv_sec + 1;
> > 			offset *= MILLION;
> > 			offset += (uint32_t)(BILLION - tp->tv_nsec)/1000;
> > 			if (next_leap_second & 1) {
> > 				/* Negative (deleted) leap second */
> > 				if ((tp->tv_nsec += offset) >= BILLION) {
> > 					tp->tv_nsec -= BILLION;
> > 					tp->tv_sec++;
> > 				}
> > 			} else {
> > 				/* Positive (inserted) leap second */
> > 				if ((tp->tv_nsec -= offset) < 0) {
> > 					tp->tv_nsec += BILLION;
> > 					tp->tv_sec--;
> > 				}
> > 			}
> > 		}
> > 		break;
> 
> Doing something like for this for gettimeofday() is pretty much obsolete 
> with the new time code. OTOH it's rather simple to smooth out the leap 
> second now, you can set time_adjust and adjust MAX_TICKADJ and the clock 
> will follow nicely.

While its possible to smooth out the leapsecond (which would be useful
to many folks), the problem is one's system would then diverge from UTC
for that leapsecond. 

The idea he's proposing here is to keep both UTC and UTS as separate
clock ids, allowing apps to choose which standard (well, I UTS isn't
quite a standard) they want to follow.

I think this would be quite useful, as I've seen a number of requests
where users don't want the leapsecond inconsistency, and others where
they need to strictly follow UTC.

I think having TAI would be nice too, but that requires quite a bit of
infrastructure work (NTP distributing absolute leapsecond counts, etc).

thanks
-john


  reply	other threads:[~2006-08-28 22:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-23  6:25 Linux time code linux
2006-08-23 18:29 ` john stultz
2006-08-24  2:35   ` linux
2006-08-28 11:39     ` Roman Zippel
2006-08-28 22:36       ` john stultz [this message]
2006-08-29  3:28         ` linux
2006-08-29 13:15           ` Theodore Tso
2006-08-29 15:18             ` linux
2006-08-29 19:23           ` john stultz
2006-08-29 14:43         ` Roman Zippel
2006-08-26  0:17   ` linux
2006-08-28 22:41     ` john stultz
2006-08-26  3:46   ` linux
  -- strict thread matches above, loose matches on Subject: below --
2006-08-16 12:26 Ulrich Windl
2006-08-16 12:36 ` Oleg Verych
2006-08-16 15:35   ` H. Peter Anvin
2006-08-16 15:12     ` Oleg Verych
2006-08-16 19:53 ` john stultz
2006-08-17  7:20   ` Ulrich Windl
2006-08-17 19:15     ` john stultz
2006-08-17 11:43   ` Roman Zippel
2006-08-17 21:58     ` john stultz
2006-08-17 22:11       ` Jesse Barnes
2006-08-17 22:32         ` john stultz
2006-08-17 22:50           ` Jesse Barnes
2006-08-17 23:02             ` john stultz
2006-08-20 17:14               ` Roman Zippel
2006-08-20 17:10       ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156804609.16398.17.camel@localhost.localdomain \
    --to=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=theotso@us.ibm.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox