From: Ian Campbell <Ian.Campbell@XenSource.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org,
Chuck Ebbert <76306.1226@compuserve.com>,
Zachary Amsden <zach@vmware.com>,
Jan Beulich <jbeulich@novell.com>, Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
Date: Thu, 31 Aug 2006 22:34:51 +0100 [thread overview]
Message-ID: <1157060091.25220.7.camel@localhost.localdomain> (raw)
In-Reply-To: <44F73429.9060101@goop.org>
On Thu, 2006-08-31 at 12:10 -0700, Jeremy Fitzhardinge wrote:
> Ian Campbell wrote:
> > smp_processor_id() is defined for !SMP in include/linux/smp.h, I don't
> > know if it would be appropriate to add early_smp_processor_id() there
> > since it seems i386 specific. asm/smp.h isn't included by linux/smp.h
> > when !SMP but you could add an explicit include to common.c I suppose.
> >
> The simple solution is to just define a !SMP version of
> early_smp_processor_id(). It's i386 specific, but that's the only arch
> that uses it:
Are you sure that works? When I tried it didn't. I think because
asm/smp.h isn't included by linux/smp.h for !SMP.
I needed the below to make it work, but including linux/smp.h and
asm/smp.h in the same file smells a bit fishy to me... Probably
acceptable for now if you are thinking of redoing SMP processor bringup
anyway.
diff -r fa530c593b97 arch/i386/kernel/cpu/common.c
--- a/arch/i386/kernel/cpu/common.c Thu Aug 31 22:28:11 2006 +0100
+++ b/arch/i386/kernel/cpu/common.c Thu Aug 31 22:33:08 2006 +0100
@@ -13,6 +13,7 @@
#include <asm/mmu_context.h>
#include <asm/mtrr.h>
#include <asm/mce.h>
+#include <asm/smp.h>
#ifdef CONFIG_X86_LOCAL_APIC
#include <asm/mpspec.h>
#include <asm/apic.h>
Ian.
next prev parent reply other threads:[~2006-08-31 21:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 23:52 [PATCH 0/8] Implement per-processor data areas for i386 Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 1/8] Use asm-offsets for the offsets of registers into the pt_regs struct, rather than having hard-coded constants Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 2/8] Basic definitions for i386-pda Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 3/8] Initialize the per-CPU data area Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 4/8] Use %gs as the PDA base-segment in the kernel Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 5/8] Fix places where using %gs changes the usermode ABI Jeremy Fitzhardinge
2006-08-31 7:11 ` Andi Kleen
2006-08-31 7:22 ` Jeremy Fitzhardinge
2006-08-31 7:36 ` Andi Kleen
2006-08-31 8:04 ` Jeremy Fitzhardinge
2006-08-31 8:13 ` Andi Kleen
2006-08-31 8:39 ` Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 6/8] Update sys_vm86 to cope with changed pt_regs and %gs usage Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 7/8] Implement smp_processor_id() with the PDA Jeremy Fitzhardinge
2006-08-31 12:35 ` Ian Campbell
2006-08-31 16:04 ` Jeremy Fitzhardinge
2006-08-31 19:10 ` Jeremy Fitzhardinge
2006-08-31 21:34 ` Ian Campbell [this message]
2006-08-31 21:39 ` Jeremy Fitzhardinge
2006-08-30 23:52 ` [PATCH 8/8] Implement "current" " Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2006-09-01 6:47 [PATCH 0/8] Implement per-processor data areas for i386 Jeremy Fitzhardinge
2006-09-01 6:47 ` [PATCH 7/8] Implement smp_processor_id() with the PDA Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157060091.25220.7.camel@localhost.localdomain \
--to=ian.campbell@xensource.com \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox