Re: [patch 3/9] Guest page hinting: volatile page cache.

Dave Hansen
2006-09-01T15:38:12Z

On Fri, 2006-09-01 at 17:29 +0200, Martin Schwidefsky wrote:
> On Fri, 2006-09-01 at 07:54 -0700, Dave Hansen wrote:
> > Are all of the un/likely()s in here really needed?
>
> Well, no un/likely is really needed. But they do help the compiler to
> generate better code. It IS unlikely that a page is discarded.

I know what they're _for_. ;)

I seem to recall people being poked in the past for sprinkling too many
of these things around their code. I just wanted to make sure that
there was some tangible reason for doing it, other than speculative
performance optimization.

-- Dave