From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Victor Hugo <victor@vhugo.net>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH][RFC] request_firmware examples and MODULE_FIRMWARE
Date: Mon, 04 Sep 2006 11:41:42 +0100 [thread overview]
Message-ID: <1157366503.30801.14.camel@localhost.localdomain> (raw)
In-Reply-To: <20060904083908.38953.qmail@web411.biz.mail.mud.yahoo.com>
Ar Llu, 2006-09-04 am 01:39 -0700, ysgrifennodd Victor Hugo:
> That said, here's the patch...
>
> tatic void sample_firmware_load(char *firmware, int size)
+{
+ u8 buf[size + 1];
+ memcpy(buf, firmware, size);
Please don't use this GNUism in the kernel code. It makes it very hard
to tell how much is being put on the (limited) stack. Better to use
kmalloc explicitly or a fixed size.
Rest looks sane.
--
VGER BF report: H 1.48569e-10
next parent reply other threads:[~2006-09-04 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060904083908.38953.qmail@web411.biz.mail.mud.yahoo.com>
2006-09-04 10:41 ` Alan Cox [this message]
2006-09-04 8:45 [PATCH][RFC] request_firmware examples and MODULE_FIRMWARE Victor Hugo
-- strict thread matches above, loose matches on Subject: below --
2006-09-04 2:55 Victor Hugo
2006-09-04 21:02 ` Andrew Morton
2006-09-04 21:16 ` Jon Masters
2006-09-05 7:33 ` Marcel Holtmann
2006-09-05 18:26 ` Victor Hugo
2006-09-05 19:16 ` Marcel Holtmann
2006-09-06 16:42 ` Jon Masters
2006-09-07 15:10 ` Marcel Holtmann
2006-09-07 15:01 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157366503.30801.14.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=victor@vhugo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox