Re: [PATCH 11/22][RFC] Unionfs: Lookup helper functions

Jan Engelhardt
2006-09-04T07:28:45Z

>+ if ((bopaque != -1) && (bopaque < bend))

>+ /* If we've only got negative dentries, then use the leftmost one. */
>+ if (lookupmode == INTERPOSE_REVAL) {
>+ if (dentry->d_inode) {
>+ itopd(dentry->d_inode)->uii_stale = 1;
>+ }
>+ goto out;
>+ }
>+ if (!newsize || ((oldsize < newsize) && (newsize > minsize))) {

Some places where -() and -{}

>+static int is_opaque_dir(struct dentry *dentry, int bindex)
>+{
>+ int err = 0;
>+ /* This is an opaque dir iff wh_hidden_dentry is positive */
>+ err = !!wh_hidden_dentry->d_inode;
>+out:
>+ return err;
>+}

This smells like a bool function. If so, don't call it "err" (since boolean
functions do not return "errors").

Jan Engelhardt
--

--
VGER BF report: H 8.44923e-11