Re: [PATCH 05/22][RFC] Unionfs: Copyup Functionality

Josef Sipek
2006-09-04T09:26:07Z

On Mon, Sep 04, 2006 at 08:59:08AM +0200, Jan Engelhardt wrote:
> >+ newattrs.ia_atime = old_hidden_dentry->d_inode->i_atime;
> >+ newattrs.ia_mtime = old_hidden_dentry->d_inode->i_mtime;
> >+ newattrs.ia_ctime = old_hidden_dentry->d_inode->i_ctime;
>
> How about,
>
> struct inode *ohi = old_hidden_dentry->d_inode;
> newattrs.ia_atime = ohi->i_atime;
>
> reduces typing a little.

Makes sense.

> >+ } else {
> >+ printk(KERN_ERR "Unknown inode type %d\n",
> >+ old_mode);
> >+ BUG();
> >+ }
>
> Is BUG the right thing, what do others think? (Using WARN, and set err to
> something useful?)

Well, it is definitely a condition which Unionfs doesn't expect - if it
doesn't know about the type, how could it copy it up?

> >+ if (!path)
> >+ ;
>
> Woha?!

Eeek. Good catch. The 'goto out' disappeared somehow.

Thanks for the comments.

Josef 'Jeff' Sipek.

--
Real Programmers consider "what you see is what you get" to be just as bad a
concept in Text Editors as it is in women. No, the Real Programmer wants a
"you asked for it, you got it" text editor -- complicated, cryptic,
powerful, unforgiving, dangerous.

--
VGER BF report: H 0.0308323