Re: [PATCH 15/22][RFC] Unionfs: Privileged operations workqueue

Jan Engelhardt
2006-09-04T07:41:08Z

>+void __unionfs_create(void *data)
>+{
>+ struct sioq_args *args = data;
>+
>+ args->err = vfs_create(args->u.create.parent, args->u.create.dentry,
>+ args->u.create.mode, args->u.create.nd);
>+ complete(&args->comp);
>+}

Suggestion

{
struct sioq_args *args = data;
struct create_args *c = &args->u.create;
args->err = vfs_create(c->parent, c->dentry, c->mode, c->nd);
complete(&args->comp);
}

Similar for others.

>+ union {
>+ struct deletewh_args deletewh;
>+ struct isopaque_args isopaque;
>+ struct create_args create;
>+ struct mkdir_args mkdir;
>+ struct mknod_args mknod;
>+ struct symlink_args symlink;
>+ struct unlink_args unlink;
>+ } u;

Anonymous unions (and structs) are allowed, use them if you think they sound
cool.

Jan Engelhardt
--

--
VGER BF report: H 0.127232