Re: [PATCH 18/22][RFC] Unionfs: Superblock operations

Andreas Schwab
2006-09-04T08:25:11Z

Jan Engelhardt <jengelh@linux01.gwdg.de> writes:

>>+/* final actions when unmounting a file system */
>>+static void unionfs_put_super(struct super_block *sb)
>>+{
>>+ int bindex, bstart, bend;
>>+ struct unionfs_sb_info *spd;
>>+
>>+ if ((spd = stopd(sb))) {
>
> Sugg.:
>
> if((spd = stopd(sb)) == NULL)
> return;

Better:

spd = stopd(sb);
if (!spd)
return;

Andreas.

--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."

--
VGER BF report: H 0