Re: [PATCH 05/22][RFC] Unionfs: Copyup Functionality

Josef Sipek
2006-09-16T22:14:04Z

On Mon, Sep 04, 2006 at 12:41:58PM +0200, Jan Engelhardt wrote:
>
> >> Is BUG the right thing, what do others think? (Using WARN, and set err to
> >> something useful?)
> >
> >Well, it is definitely a condition which Unionfs doesn't expect - if it
> >doesn't know about the type, how could it copy it up?
>
> Other filesystems don't seem to BUG either (at least I have not run into
> that yet) when - for whatever reasons - the statdata of a dentry is
> fubared. `ls` just displays it then, like
>
> ?-w---Sr-T 1 root root 4294967295 date fubared_file

I was thinking about this, and the difference between "other filesystems"
and unionfs in this case is that the example above is just stat. During
copyup, unionfs has to copy the file to another filesystem. How is it
supposed to do that when it doesn't understand what the file is?

Sure, when unionfs does stat, fubared statdata is fine, but during
copyup...bad things could potentially happen.

Any suggestions how to copyup an unknown file type?

Josef 'Jeff' Sipek.

--
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
- Linus Torvalds