Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions

Jan Engelhardt
2006-09-04T07:13:12Z

>+/* This filldir function makes sure only whiteouts exist within a directory. */
>+static int readdir_util_callback(void *dirent, const char *name, int namelen,
>+ loff_t offset, ino_t ino, unsigned int d_type)
>+{
>+ int err = 0;
>+ struct unionfs_rdutil_callback *buf =
>+ (struct unionfs_rdutil_callback *)dirent;

Nocast.

>+ if ((namelen > UNIONFS_WHLEN) && !strncmp(name, UNIONFS_WHPFX, UNIONFS_WHLEN)) {
()
Also elsewhere.

>+ if (0 <= bopaque && bopaque < bend)

Turn it. Constant values are usually wanted on the right side.

bopaque >= 0

Jan Engelhardt
--

--
VGER BF report: H 1.55431e-15