From: Adam Belay <abelay@novell.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Len Brown <len.brown@intel.com>,
ACPI ML <linux-acpi@vger.kernel.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [RFC][PATCH 1/2] ACPI: Idle Processor PM Improvements
Date: Mon, 04 Sep 2006 22:19:49 -0400 [thread overview]
Message-ID: <1157422789.3777.17.camel@localhost.localdomain> (raw)
In-Reply-To: <20060904125921.GB6279@ucw.cz>
Hi Pavel,
On Mon, 2006-09-04 at 12:59 +0000, Pavel Machek wrote:
> Hi!
>
> > This patch improves the ACPI c-state selection algorithm. It also
> > includes a major cleanup and simplification of the processor idle code.
>
> Nice!
>
> > @@ -1009,7 +883,7 @@
> >
> > seq_printf(seq, "active state: C%zd\n"
> > "max_cstate: C%d\n"
> > - "bus master activity: %08x\n",
> > + "bus master activity: %d\n",
> > pr->power.state ? pr->power.state - pr->power.states : 0,
> > max_cstate, (unsigned)pr->power.bm_activity);
> >
>
> This changes kernel - user interface. You should change the field
> description, or keep it in hex...
Good catch! Essentially the field now counts the number of times bus
master activity was detected, rather than bitshifting. I'll change its
name in the next iteration.
>
> BTW will you be on september's labs conference?
It's not currently in my plans, but I'd love to attend one at some
point.
>
> Pavel
Thanks for the comments.
Regards,
Adam
next prev parent reply other threads:[~2006-09-05 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 20:51 [RFC][PATCH 1/2] ACPI: Idle Processor PM Improvements Adam Belay
2006-09-04 12:59 ` Pavel Machek
2006-09-05 2:19 ` Adam Belay [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-30 18:40 Pallipadi, Venkatesh
2006-08-30 19:43 ` Matthew Garrett
2006-08-31 23:13 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157422789.3777.17.camel@localhost.localdomain \
--to=abelay@novell.com \
--cc=arjan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox