From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Ian Kent <raven@themaw.net>
Cc: David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, steved@redhat.com,
linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com,
nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13]
Date: Tue, 05 Sep 2006 00:17:29 -0400 [thread overview]
Message-ID: <1157429849.32412.16.camel@localhost> (raw)
In-Reply-To: <1157429474.3915.14.camel@raven.themaw.net>
On Tue, 2006-09-05 at 12:11 +0800, Ian Kent wrote:
> On Mon, 2006-09-04 at 14:46 +0100, David Howells wrote:
> > Ian Kent <raven@themaw.net> wrote:
> >
> > > This is the point I'm trying to make.
> > > I'm able to reproduce this with exports that don't have "nohide".
> > > The mkdir used to return EEXIST, possibly before getting to the EACCES
> > > test. It appears to be a change in semantic behavior and I can't see
> > > where it is coming from. autofs expects an EEXIST but not an EACCES and
> > > so doesn't perform the mount. I could ignore the EACCES but that would
> > > be cheating.
> >
> > Here's something you can try: Look in fs/nfs/dir.c. Find nfs_lookup(). In
> > there, find the following lines:
> >
> > /* If we're doing an exclusive create, optimize away the lookup */
> > if (nfs_is_exclusive_create(dir, nd))
> > goto no_entry;
> >
> > Comment that bit out and see what the effect it.
>
> Yes.
>
> Commenting this out results in the expected behavior.
> No doubt this is because the following NFS lookup to the server returns
> EEXIST which is then returned to userspace.
It also breaks open(O_EXCL). Removing that is unacceptable.
next prev parent reply other threads:[~2006-09-05 4:17 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 19:31 [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13] David Howells
2006-08-30 19:31 ` [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit " David Howells
2006-08-30 19:32 ` [PATCH 3/7] FS-Cache: Release page->private after failed readahead " David Howells
2006-08-30 19:32 ` [PATCH 4/7] FS-Cache: Make kAFS use FS-Cache " David Howells
2006-08-30 19:32 ` [PATCH 5/7] NFS: Use local caching " David Howells
2006-08-30 19:32 ` [PATCH 6/7] FS-Cache: CacheFiles: ia64: missing copy_page export " David Howells
2006-08-30 19:52 ` [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing " Andrew Morton
2006-08-30 20:37 ` David Howells
2006-08-30 20:55 ` Andrew Morton
2006-08-31 9:58 ` David Howells
2006-08-31 17:21 ` Andrew Morton
2006-08-31 17:26 ` Trond Myklebust
2006-08-31 17:42 ` David Howells
2006-08-31 18:04 ` Andrew Morton
2006-09-01 13:08 ` David Howells
2006-09-01 16:34 ` Andrew Morton
2006-09-01 17:00 ` Trond Myklebust
2006-09-02 2:50 ` Andrew Morton
2006-09-02 4:11 ` Ian Kent
2006-09-02 5:58 ` Andrew Morton
2006-09-03 6:21 ` Ian Kent
2006-09-03 6:30 ` Andrew Morton
2006-09-03 6:43 ` Ian Kent
2006-09-03 16:58 ` Andrew Morton
2006-09-04 2:23 ` Ian Kent
2006-09-04 5:40 ` Ian Kent
2006-09-02 4:49 ` Ian Kent
2006-09-04 11:52 ` David Howells
2006-09-04 11:52 ` David Howells
2006-09-04 13:24 ` Ian Kent
2006-09-04 13:46 ` David Howells
2006-09-04 15:00 ` Ian Kent
2006-09-05 4:11 ` Ian Kent
2006-09-05 4:17 ` Trond Myklebust [this message]
2006-09-05 1:57 ` Trond Myklebust
2006-09-05 2:55 ` Ian Kent
2006-09-05 3:50 ` Trond Myklebust
2006-09-05 4:03 ` Ian Kent
2006-09-05 4:53 ` Trond Myklebust
2006-09-05 6:06 ` Ian Kent
2006-09-05 7:01 ` Ian Kent
2006-09-05 12:52 ` Trond Myklebust
2006-09-06 4:54 ` Ian Kent
2006-09-05 9:40 ` David Howells
2006-09-05 10:20 ` Ian Kent
2006-09-05 10:37 ` David Howells
2006-09-05 12:20 ` Ian Kent
2006-09-05 13:38 ` David Howells
2006-09-06 4:58 ` Ian Kent
2006-09-06 9:51 ` David Howells
2006-09-06 12:46 ` Trond Myklebust
2006-09-06 13:24 ` David Howells
2006-09-07 5:30 ` Ian Kent
2006-09-07 6:17 ` Trond Myklebust
2006-09-07 7:40 ` Ian Kent
2006-09-05 9:48 ` David Howells
2006-09-05 10:14 ` Ian Kent
2006-09-05 9:57 ` David Howells
2006-09-05 12:47 ` Trond Myklebust
2006-09-05 12:53 ` Trond Myklebust
2006-09-05 13:40 ` David Howells
2006-09-06 10:27 ` Ian Kent
2006-09-05 2:23 ` Trond Myklebust
2006-09-05 3:01 ` Ian Kent
2006-09-05 4:05 ` Trond Myklebust
2006-09-05 4:06 ` Ian Kent
2006-09-05 4:57 ` Trond Myklebust
2006-09-05 6:45 ` Ian Kent
2006-09-05 7:07 ` Ian Kent
2006-09-04 18:20 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157429849.32412.16.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=raven@themaw.net \
--cc=steved@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox