Re: 2.6.18-rc5-mm1

Dmitry Torokhov
2006-09-02T01:33:38Z

On Friday 01 September 2006 21:12, Dmitry Torokhov wrote:
> On Friday 01 September 2006 21:06, Grant Coady wrote:
> > On Fri, 1 Sep 2006 01:58:18 -0700, Andrew Morton <akpm@osdl.org> wrote:
> >
> > >
> > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc5/2.6.18-rc5-mm1/
> > ...
> > >- See the `hot-fixes' directory for any important updates to this patchset.
> > >
> > Okay, I applied hotfixes and it crashed on boot, keyboard LEDs flashing:
> >
> > Repeating message, hand copied:
> > atkbd.c: Spurious ACK in isa0060/serio0. Some program might be trying access
> > hardware directly.
> >
>
> Please try booting with i8042.panicblink=0 to see the real oops (important
> data).

.. or try the patch below.

--
Dmitry

Input: i8042 - disable keyboard port when panicking and blinking

This should get rid of "spurious ACK" messages from atkbd driver
during panic.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---

drivers/input/serio/i8042.c | 7 +++++++
1 files changed, 7 insertions(+)

Index: work/drivers/input/serio/i8042.c
===================================================================
--- work.orig/drivers/input/serio/i8042.c
+++ work/drivers/input/serio/i8042.c
@@ -836,9 +836,16 @@ static long i8042_panic_blink(long count
*/
if (!i8042_blink_frequency)
return 0;
+
if (count - last_blink < i8042_blink_frequency)
return 0;

+ /*
+ * Disable keyboard port so ATKBD won't fill logs with
+ * "spurious ACK" messages
+ */
+ i8042_ports[I8042_KBD_PORT_NO].exists = 0;
+
led ^= 0x01 | 0x04;
while (i8042_read_status() & I8042_STR_IBF)
DELAY;

--
VGER BF report: H 0