From: Steven Whitehouse <swhiteho@redhat.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: David Teigland <teigland@redhat.com>,
linux-kernel@vger.kernel.org,
Russell Cattelan <cattelan@redhat.com>,
Ingo Molnar <mingo@elte.hu>,
hch@infradead.org
Subject: Re: [PATCH 14/16] GFS2: The DLM interface module
Date: Fri, 08 Sep 2006 10:26:18 +0100 [thread overview]
Message-ID: <1157707578.11901.13.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0609071832330.24855@yvahk01.tjqt.qr>
Hi,
On Thu, 2006-09-07 at 18:35 +0200, Jan Engelhardt wrote:
> Hi David,
>
>
> >> >+int gdlm_get_lock(lm_lockspace_t *lockspace, struct lm_lockname *name,
> >> >+ lm_lock_t **lockp)
> >>
> >> [lm_lock_t is]
> >> currently typedef'ed to void [...]. (One _could_
> >> get rid of it, but better not while it is called lm_lock_t. Leave as-is
> >> for now.)
> >
> >I'm wondering what you might suggest instead of using the lm_lockspace_t,
> >lm_lock_t, lm_fsdata_t typedefs. These are opaque objects passed between
> >gfs and the lock modules. Could you give an example or point to some code
> >that shows what you're thinking?
>
> What I was thinking about:
> int gdlm_get_lock(void *lockspace, struct lm_lockname *name, void **lockp)
>
>
> Jan Engelhardt
I've had a bash at this and the results are here:
http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6.git;a=commitdiff;h=9b47c11d1cbedcba685c9bd90c73fd41acdfab0e
Let me know if thats ok,
Steve.
next prev parent reply other threads:[~2006-09-08 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 13:41 [PATCH 14/16] GFS2: The DLM interface module Steven Whitehouse
2006-09-05 12:05 ` Jan Engelhardt
2006-09-07 9:01 ` Steven Whitehouse
2006-09-07 14:58 ` David Teigland
2006-09-07 16:35 ` Jan Engelhardt
2006-09-08 9:26 ` Steven Whitehouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-21 16:23 Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157707578.11901.13.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=cattelan@redhat.com \
--cc=hch@infradead.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox