From: Hil <ubuntu@comcast.net>
To: "Andrew J. Kroll" <ag784@freenet.sis.buffalo.edu>,
kernel-janitor-discuss@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Cc: Eberhard Moenkeberg <emoenke@gwdg.de>
Subject: sbpcd.c: fix check_region to request_region
Date: Tue, 12 Sep 2006 00:22:13 -0700 [thread overview]
Message-ID: <1158045733.23931.16.camel@localhost> (raw)
I looked at Linux Kernel Janitor project. There is a request of fixing
the old check_region function to request_region function. I did a grep
on the source tree and found several check_region. I will continue
fixing them after this patch is accepted. Please tell me if I'm doing
the submission correctly.
ChangeLog
- The file needs to be patched because it used deprecated check_region
function
- The check_region in the file simply checks if the region of memory is
available. I replaced that line with request_region followed by
release_region to make the check
- I do not have testing result available. I am sending this email to the
maintainer for testing. The maintainer probably has the specific CD-ROMs
to test my patch.
The kernel version for the patch is 2.6.18-rc6
--- linux-2.6.17/drivers/cdrom/sbpcd.c~ 2006-09-11 14:19:53.000000000
-0700
+++ linux-2.6.17/drivers/cdrom/sbpcd.c 2006-09-11 23:47:48.000000000
-0700
@@ -5671,11 +5671,12 @@ int __init sbpcd_init(void)
{
addr[1]=sbpcd[port_index];
if (addr[1]==0) break;
- if (check_region(addr[1],4))
+ if (!request_region(addr[1],4,major_name))
{
msg(DBG_INF,"check_region: %03X is not free.\n",addr[1]);
continue;
}
+ release_region(addr[1],4);
if (sbpcd[port_index+1]==2) type=str_sp;
else if (sbpcd[port_index+1]==1) type=str_sb;
else if (sbpcd[port_index+1]==3) type=str_t16;
Signed-off-by: Hil Liao <ubuntu@comcast.net>
reply other threads:[~2006-09-12 7:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158045733.23931.16.camel@localhost \
--to=ubuntu@comcast.net \
--cc=ag784@freenet.sis.buffalo.edu \
--cc=emoenke@gwdg.de \
--cc=freehil@gmail.com \
--cc=kernel-janitor-discuss@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox