From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Organov <osv@javad.com>
Cc: Andrew Bird <ajb@spheresystems.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: Spinlock debugging
Date: Tue, 12 Sep 2006 15:04:27 +0100 [thread overview]
Message-ID: <1158069868.6780.18.camel@localhost.localdomain> (raw)
In-Reply-To: <87ac55yzx3.fsf@javad.com>
Ar Maw, 2006-09-12 am 17:31 +0400, ysgrifennodd Sergei Organov:
> Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> [...]
> > So all you need in your IRQ handler is
> >
> > if (tty_insert_flip_string(tty, buf, size))
> > tty_flip_buffer_push(tty);
>
> What is the purpose of the "if" in the above code? is push with no data
> in the buffer dangerous? Or is it just optimization of
> almost-never-taken path? ;)
Sorry..replied to sender only
It's an optimisation and you are right it may well not even be worth
doing
prev parent reply other threads:[~2006-09-12 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 15:32 Spinlock debugging Andrew Bird (Sphere Systems)
2006-09-11 16:36 ` Alan Cox
2006-09-11 16:38 ` Andrew Bird
2006-09-11 17:24 ` Alan Cox
2006-09-12 7:47 ` Andrew Bird
2006-09-12 13:43 ` Alan Cox
2006-09-12 13:31 ` Sergei Organov
2006-09-12 14:04 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158069868.6780.18.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ajb@spheresystems.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=osv@javad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox