* [Patch 4/7] megaraid_sas: adds reboot handler
@ 2006-09-21 2:02 Sumant Patro
2006-09-21 11:44 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Sumant Patro @ 2006-09-21 2:02 UTC (permalink / raw)
To: James.Bottomley, linux-scsi; +Cc: akpm, hch, linux-kernel, Neela.Kolli, Bo.Yang
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
This patch adds handler to get reboot notification and fires flush command from
the reboot notification handler.
Signed-off-by: Sumant Patro <Sumant.Patro@lsil.com>
diff -uprN linux-2.6orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6new/drivers/scsi/megaraid/megaraid_sas.c
--- linux-2.6orig/drivers/scsi/megaraid/megaraid_sas.c 2006-09-20 11:04:34.000000000 -0700
+++ linux-2.6new/drivers/scsi/megaraid/megaraid_sas.c 2006-09-20 11:05:52.000000000 -0700
@@ -36,6 +36,8 @@
#include <linux/fs.h>
#include <linux/compat.h>
#include <linux/mutex.h>
+#include <linux/reboot.h>
+#include <linux/notifier.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
@@ -2351,6 +2353,36 @@ static void megasas_flush_cache(struct m
}
/**
+ * megasas_reboot_notify- Flush adapter cache
+ * @this: Our notifier block
+ * @code: The event notified
+ * @unused: Unused
+ */
+static int
+megasas_reboot_notify (struct notifier_block *this, unsigned long code,
+ void *unused)
+{
+ struct megasas_instance *instance;
+ int i;
+
+ for (i = 0; i < megasas_mgmt_info.max_index; i++) {
+ instance = megasas_mgmt_info.instance[i];
+ if (instance) {
+ megasas_flush_cache(instance);
+ }
+ }
+
+ return NOTIFY_DONE;
+}
+
+/**
+ * notifier block to get notification on system halt/reboot/shutdown/power off
+ */
+static struct notifier_block megasas_notifier = {
+ .notifier_call = megasas_reboot_notify
+};
+
+/**
* megasas_shutdown_controller - Instructs FW to shutdown the controller
* @instance: Adapter soft state
*/
@@ -2903,6 +2935,10 @@ static int __init megasas_init(void)
driver_create_file(&megasas_pci_driver.driver,
&driver_attr_release_date);
+ if(register_reboot_notifier(&megasas_notifier)) {
+ printk("megasas: reboot notify routine registration failed!!\n");
+ }
+
return rval;
}
@@ -2917,6 +2953,7 @@ static void __exit megasas_exit(void)
pci_unregister_driver(&megasas_pci_driver);
unregister_chrdev(megasas_mgmt_majorno, "megaraid_sas_ioctl");
+ unregister_reboot_notifier(&megasas_notifier);
}
module_init(megasas_init);
[-- Attachment #2: reboot_noti-p4.patch --]
[-- Type: text/x-patch, Size: 1911 bytes --]
diff -uprN linux-2.6orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6new/drivers/scsi/megaraid/megaraid_sas.c
--- linux-2.6orig/drivers/scsi/megaraid/megaraid_sas.c 2006-09-20 11:04:34.000000000 -0700
+++ linux-2.6new/drivers/scsi/megaraid/megaraid_sas.c 2006-09-20 11:05:52.000000000 -0700
@@ -36,6 +36,8 @@
#include <linux/fs.h>
#include <linux/compat.h>
#include <linux/mutex.h>
+#include <linux/reboot.h>
+#include <linux/notifier.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
@@ -2351,6 +2353,36 @@ static void megasas_flush_cache(struct m
}
/**
+ * megasas_reboot_notify- Flush adapter cache
+ * @this: Our notifier block
+ * @code: The event notified
+ * @unused: Unused
+ */
+static int
+megasas_reboot_notify (struct notifier_block *this, unsigned long code,
+ void *unused)
+{
+ struct megasas_instance *instance;
+ int i;
+
+ for (i = 0; i < megasas_mgmt_info.max_index; i++) {
+ instance = megasas_mgmt_info.instance[i];
+ if (instance) {
+ megasas_flush_cache(instance);
+ }
+ }
+
+ return NOTIFY_DONE;
+}
+
+/**
+ * notifier block to get notification on system halt/reboot/shutdown/power off
+ */
+static struct notifier_block megasas_notifier = {
+ .notifier_call = megasas_reboot_notify
+};
+
+/**
* megasas_shutdown_controller - Instructs FW to shutdown the controller
* @instance: Adapter soft state
*/
@@ -2903,6 +2935,10 @@ static int __init megasas_init(void)
driver_create_file(&megasas_pci_driver.driver,
&driver_attr_release_date);
+ if(register_reboot_notifier(&megasas_notifier)) {
+ printk("megasas: reboot notify routine registration failed!!\n");
+ }
+
return rval;
}
@@ -2917,6 +2953,7 @@ static void __exit megasas_exit(void)
pci_unregister_driver(&megasas_pci_driver);
unregister_chrdev(megasas_mgmt_majorno, "megaraid_sas_ioctl");
+ unregister_reboot_notifier(&megasas_notifier);
}
module_init(megasas_init);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 4/7] megaraid_sas: adds reboot handler
2006-09-21 2:02 [Patch 4/7] megaraid_sas: adds reboot handler Sumant Patro
@ 2006-09-21 11:44 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2006-09-21 11:44 UTC (permalink / raw)
To: Sumant Patro
Cc: James.Bottomley, linux-scsi, akpm, hch, linux-kernel, Neela.Kolli,
Bo.Yang
On Wed, Sep 20, 2006 at 07:02:51PM -0700, Sumant Patro wrote:
> This patch adds handler to get reboot notification and fires flush command from
> the reboot notification handler.
NACK, this should be handled by the PCI driver ->shutdown method instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Patch 4/7] megaraid_sas: adds reboot handler
@ 2006-09-21 21:36 Patro, Sumant
0 siblings, 0 replies; 3+ messages in thread
From: Patro, Sumant @ 2006-09-21 21:36 UTC (permalink / raw)
To: Christoph Hellwig
Cc: James.Bottomley, linux-scsi, akpm, hch, linux-kernel,
Kolli, Neela, Yang, Bo
I agree.
Regards,
Sumant
-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Thursday, September 21, 2006 4:44 AM
To: Patro, Sumant
Cc: James.Bottomley@SteelEye.com; linux-scsi@vger.kernel.org;
akpm@osdl.org; hch@lst.de; linux-kernel@vger.kernel.org; Kolli, Neela;
Yang, Bo
Subject: Re: [Patch 4/7] megaraid_sas: adds reboot handler
On Wed, Sep 20, 2006 at 07:02:51PM -0700, Sumant Patro wrote:
> This patch adds handler to get reboot notification and fires flush
command from
> the reboot notification handler.
NACK, this should be handled by the PCI driver ->shutdown method
instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-21 21:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-21 2:02 [Patch 4/7] megaraid_sas: adds reboot handler Sumant Patro
2006-09-21 11:44 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2006-09-21 21:36 Patro, Sumant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox