From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Luke Yang <luke.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 4/4] Blackfin: binfmt patch to enhance stacking checking
Date: Thu, 21 Sep 2006 10:22:00 +0100 [thread overview]
Message-ID: <1158830520.11109.91.camel@localhost.localdomain> (raw)
In-Reply-To: <489ecd0c0609202033l456d66ceq85ef69e7a4a4aa00@mail.gmail.com>
Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> diff -urN linux-2.6.18.patch2/fs/binfmt_elf_fdpic.c
> linux-2.6.18.patch3/fs/binfmt_elf_fdpic.c
> --- linux-2.6.18.patch2/fs/binfmt_elf_fdpic.c 2006-09-21
> 09:37:18.000000000 +0800
> +++ linux-2.6.18.patch3/fs/binfmt_elf_fdpic.c 2006-09-21
> 11:17:49.000000000 +0800
> @@ -959,6 +962,8 @@
> }
> #endif
>
> +extern void *safe_dma_memcpy(void *, const void *, size_t);
> +
This shouldn't be here but in your header files for the arch (or in
linux/ somewhere if its a shared and missing include). Check and fix the
headers.
> if (strncmp(hdr->magic, "#!", 2))
> printk("BINFMT_FLAT: bad header magic\n");
> - ret = -ENOEXEC;
> - goto err;
> + return -ENOEXEC;
These changes seem unneccessary and its hard to see the real change as a
result.
next prev parent reply other threads:[~2006-09-21 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 3:33 [PATCH 4/4] Blackfin: binfmt patch to enhance stacking checking Luke Yang
2006-09-21 6:04 ` Randy.Dunlap
[not found] ` <489ecd0c0609210041t484296e5kf94203ecee13514a@mail.gmail.com>
2006-09-21 7:43 ` Luke Yang
2006-09-21 15:56 ` Randy.Dunlap
2006-09-21 9:22 ` Alan Cox [this message]
2006-09-21 10:52 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158830520.11109.91.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox