* Re: [S390] remove old z90crypt driver.
[not found] <200609222101.k8ML1w93019317@hera.kernel.org>
@ 2006-09-24 20:51 ` David Woodhouse
2006-09-25 8:11 ` Martin Schwidefsky
0 siblings, 1 reply; 3+ messages in thread
From: David Woodhouse @ 2006-09-24 20:51 UTC (permalink / raw)
To: Martin Schwidefsky, akpm; +Cc: Linux Kernel Mailing List
On Fri, 2006-09-22 at 21:01 +0000, Linux Kernel Mailing List wrote:
> [S390] remove old z90crypt driver.
>
> The z90crypt driver has served its term. It is replaced by the shiny
> new zcrypt device driver.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
You neglected to remove the defunct z90crypt.h from
include/asm-s390/Kbuild, breaking 'make headers_install' on s390.
You also neglected to export the new asm/zcrypt.h too. This should fix
both:
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
--- a/include/asm-s390/Kbuild
+++ b/include/asm-s390/Kbuild
@@ -6,7 +6,7 @@ header-y += qeth.h
header-y += tape390.h
header-y += ucontext.h
header-y += vtoc.h
-header-y += z90crypt.h
+header-y += zcrypt.h
unifdef-y += cmb.h
unifdef-y += debug.h
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [S390] remove old z90crypt driver.
2006-09-24 20:51 ` [S390] remove old z90crypt driver David Woodhouse
@ 2006-09-25 8:11 ` Martin Schwidefsky
2006-09-25 8:18 ` David Woodhouse
0 siblings, 1 reply; 3+ messages in thread
From: Martin Schwidefsky @ 2006-09-25 8:11 UTC (permalink / raw)
To: David Woodhouse; +Cc: akpm, Linux Kernel Mailing List
On Sun, 2006-09-24 at 21:51 +0100, David Woodhouse wrote:
> You neglected to remove the defunct z90crypt.h from
> include/asm-s390/Kbuild, breaking 'make headers_install' on s390.
>
> You also neglected to export the new asm/zcrypt.h too. This should fix
> both:
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> --- a/include/asm-s390/Kbuild
> +++ b/include/asm-s390/Kbuild
> @@ -6,7 +6,7 @@ header-y += qeth.h
> header-y += tape390.h
> header-y += ucontext.h
> header-y += vtoc.h
> -header-y += z90crypt.h
> +header-y += zcrypt.h
>
> unifdef-y += cmb.h
> unifdef-y += debug.h
>
Unfortunately true. The patches for the new crypto driver originate from
before headers_install. I forgot to update them accordingly ..
Anyway, thanks for the heads up. I'll add the patch to git390.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [S390] remove old z90crypt driver.
2006-09-25 8:11 ` Martin Schwidefsky
@ 2006-09-25 8:18 ` David Woodhouse
0 siblings, 0 replies; 3+ messages in thread
From: David Woodhouse @ 2006-09-25 8:18 UTC (permalink / raw)
To: schwidefsky; +Cc: akpm, Linux Kernel Mailing List
On Mon, 2006-09-25 at 10:11 +0200, Martin Schwidefsky wrote:
> Unfortunately true. The patches for the new crypto driver originate from
> before headers_install. I forgot to update them accordingly ..
> Anyway, thanks for the heads up. I'll add the patch to git390.
It's in Linus' tree already.
--
dwmw2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-25 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200609222101.k8ML1w93019317@hera.kernel.org>
2006-09-24 20:51 ` [S390] remove old z90crypt driver David Woodhouse
2006-09-25 8:11 ` Martin Schwidefsky
2006-09-25 8:18 ` David Woodhouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox