From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restore libata build on frv
Date: Mon, 25 Sep 2006 16:46:23 +0100 [thread overview]
Message-ID: <1159199184.11049.93.camel@localhost.localdomain> (raw)
In-Reply-To: <20660.1159195152@warthog.cambridge.redhat.com>
Ar Llu, 2006-09-25 am 15:39 +0100, ysgrifennodd David Howells:
> Why does the arch have to supply those numbers? What's wrong with my
> suggested patch? According to code in libata, these are _legacy_ access
> methods, and on FRV they aren't currently required, so why can't I dispense
"legacy, legacy, legacy" "wont wont wont"
The ports in question are PCI values. They come from the PCI
specifications and apply to any device with PCI bus, unless it has
special mappings. The same logic you are whining about is already partly
handled in the generic pci quirks code, and in time will end up with the
I/O port value fixups there anyway.
See quirk_ide_bases in drivers/pci/quirks.c
Go read the specifications and stop whining about legacy ports and ISA
bus for things that are not.
Ack Al Viro's changes but with IRQ set to zero.
Alan
next prev parent reply other threads:[~2006-09-25 15:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-24 22:39 [PATCH] restore libata build on frv Al Viro
2006-09-25 10:44 ` David Howells
2006-09-25 11:26 ` Alan Cox
2006-09-25 11:04 ` Russell King
2006-09-25 11:28 ` David Howells
2006-09-25 11:27 ` David Howells
2006-09-25 12:19 ` Alan Cox
2006-09-25 12:18 ` David Howells
2006-09-25 14:20 ` Al Viro
2006-09-25 14:39 ` David Howells
2006-09-25 15:46 ` Alan Cox [this message]
2006-09-25 16:04 ` David Howells
2006-09-25 16:21 ` Al Viro
2006-09-26 8:06 ` David Woodhouse
2006-09-26 8:52 ` Jeff Garzik
2006-09-26 8:56 ` David Woodhouse
2006-09-26 11:25 ` Alan Cox
2006-09-26 11:30 ` Alan Cox
2006-09-26 16:15 ` Linus Torvalds
2006-09-26 17:25 ` David Howells
2006-09-26 20:21 ` David Woodhouse
2006-09-27 7:05 ` David Woodhouse
2006-09-25 15:39 ` Alan Cox
2006-09-25 15:45 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159199184.11049.93.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox