public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Cc: David Brownell <david-b@pacbell.net>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Andrew Morton <akpm@osdl.org>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 17/47] PM: issue PM_EVENT_PRETHAW
Date: Mon, 25 Sep 2006 22:37:37 -0700	[thread overview]
Message-ID: <11592491371254-git-send-email-greg@kroah.com> (raw)
In-Reply-To: <11592491342421-git-send-email-greg@kroah.com>

From: David Brownell <david-b@pacbell.net>

This patch is the first of this series that should actually change any
behavior ...  by issuing the new event, now tha the rest of the kernel is
prepared to receive it.

This converts the PM core to issue the new PRETHAW message, which the rest of
the kernel is now ready to receive.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/power/suspend.c |    1 +
 kernel/power/disk.c          |    4 ++--
 kernel/power/swsusp.c        |    9 ++++++++-
 kernel/power/user.c          |    2 +-
 4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/base/power/suspend.c b/drivers/base/power/suspend.c
index 0bda4a7..e86db83 100644
--- a/drivers/base/power/suspend.c
+++ b/drivers/base/power/suspend.c
@@ -34,6 +34,7 @@ static inline char *suspend_verb(u32 eve
 	switch (event) {
 	case PM_EVENT_SUSPEND:	return "suspend";
 	case PM_EVENT_FREEZE:	return "freeze";
+	case PM_EVENT_PRETHAW:	return "prethaw";
 	default:		return "(unknown suspend event)";
 	}
 }
diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index e13e740..a3c34fb 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -98,7 +98,7 @@ static void unprepare_processes(void)
 }
 
 /**
- *	pm_suspend_disk - The granpappy of power management.
+ *	pm_suspend_disk - The granpappy of hibernation power management.
  *
  *	If we're going through the firmware, then get it over with quickly.
  *
@@ -207,7 +207,7 @@ static int software_resume(void)
 
 	pr_debug("PM: Preparing devices for restore.\n");
 
-	if ((error = device_suspend(PMSG_FREEZE))) {
+	if ((error = device_suspend(PMSG_PRETHAW))) {
 		printk("Some devices failed to suspend\n");
 		swsusp_free();
 		goto Thaw;
diff --git a/kernel/power/swsusp.c b/kernel/power/swsusp.c
index 17f669c..6275289 100644
--- a/kernel/power/swsusp.c
+++ b/kernel/power/swsusp.c
@@ -248,6 +248,9 @@ int swsusp_suspend(void)
 	restore_processor_state();
 Restore_highmem:
 	restore_highmem();
+	/* NOTE:  device_power_up() is just a resume() for devices
+	 * that suspended with irqs off ... no overall powerup.
+	 */
 	device_power_up();
 Enable_irqs:
 	local_irq_enable();
@@ -257,8 +260,12 @@ Enable_irqs:
 int swsusp_resume(void)
 {
 	int error;
+
 	local_irq_disable();
-	if (device_power_down(PMSG_FREEZE))
+	/* NOTE:  device_power_down() is just a suspend() with irqs off;
+	 * it has no special "power things down" semantics
+	 */
+	if (device_power_down(PMSG_PRETHAW))
 		printk(KERN_ERR "Some devices failed to power down, very bad\n");
 	/* We'll ignore saved state, but this gets preempt count (etc) right */
 	save_processor_state();
diff --git a/kernel/power/user.c b/kernel/power/user.c
index 3f1539f..5a8d060 100644
--- a/kernel/power/user.c
+++ b/kernel/power/user.c
@@ -191,7 +191,7 @@ static int snapshot_ioctl(struct inode *
 		}
 		down(&pm_sem);
 		pm_prepare_console();
-		error = device_suspend(PMSG_FREEZE);
+		error = device_suspend(PMSG_PRETHAW);
 		if (!error) {
 			error = swsusp_resume();
 			device_resume();
-- 
1.4.2.1


  reply	other threads:[~2006-09-26  5:39 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26  5:37 [GIT PATCH] Driver Core patches for 2.6.18 Greg KH
2006-09-26  5:37 ` [PATCH 1/47] Documentation/ABI: devfs is not obsolete, but removed! Greg KH
2006-09-26  5:37   ` [PATCH 2/47] deprecate PHYSDEV* keys Greg KH
2006-09-26  5:37     ` [PATCH 3/47] class_device_create(): make fmt argument 'const char *' Greg KH
2006-09-26  5:37       ` [PATCH 4/47] device_create(): " Greg KH
2006-09-26  5:37         ` [PATCH 5/47] Driver core: add const to class_create Greg KH
2006-09-26  5:37           ` [PATCH 6/47] sysfs: Make poll behaviour consistent Greg KH
2006-09-26  5:37             ` [PATCH 7/47] Debugfs: kernel-doc fixes for debugfs Greg KH
2006-09-26  5:37               ` [PATCH 8/47] SYSFS: allow sysfs_create_link to create symlinks in the root of sysfs Greg KH
2006-09-26  5:37                 ` [PATCH 9/47] Suspend infrastructure cleanup and extension Greg KH
2006-09-26  5:37                   ` [PATCH 10/47] Suspend changes for PCI core Greg KH
2006-09-26  5:37                     ` [PATCH 11/47] make suspend quieter Greg KH
2006-09-26  5:37                       ` [PATCH 12/47] fix broken/dubious driver suspend() methods Greg KH
2006-09-26  5:37                         ` [PATCH 13/47] PM: define PM_EVENT_PRETHAW Greg KH
2006-09-26  5:37                           ` [PATCH 14/47] PM: PCI and IDE handle PM_EVENT_PRETHAW Greg KH
2006-09-26  5:37                             ` [PATCH 15/47] PM: video drivers and PM_EVENT_PRETHAW Greg KH
2006-09-26  5:37                               ` [PATCH 16/47] PM: USB HCDs use PM_EVENT_PRETHAW Greg KH
2006-09-26  5:37                                 ` Greg KH [this message]
2006-09-26  5:37                                   ` [PATCH 18/47] updated Documentation/power/devices.txt Greg KH
2006-09-26  5:37                                     ` [PATCH 19/47] PM: update docs for writing .../power/state Greg KH
2006-09-26  5:37                                       ` [PATCH 20/47] PM: add kconfig option for deprecated .../power/state files Greg KH
2006-09-26  5:37                                         ` [PATCH 21/47] PM: schedule /sys/devices/.../power/state for removal Greg KH
2006-09-26  5:37                                           ` [PATCH 22/47] PM: no suspend_prepare() phase Greg KH
2006-09-26  5:37                                             ` [PATCH 23/47] PM: add /sys/power documentation to Documentation/ABI Greg KH
2006-09-26  5:37                                               ` [PATCH 24/47] PM: device_suspend/resume may sleep Greg KH
2006-09-26  5:37                                                 ` [PATCH 25/47] PM: platform_bus and late_suspend/early_resume Greg KH
2006-09-26  5:37                                                   ` [PATCH 26/47] Driver core: add groups support to struct device Greg KH
2006-09-26  5:37                                                     ` [PATCH 27/47] Driver core: allow devices in classes to have no parent Greg KH
2006-09-26  5:37                                                       ` [PATCH 28/47] Driver core: add ability for classes to handle devices properly Greg KH
2006-09-26  5:37                                                         ` [PATCH 29/47] Driver core: add device_rename function Greg KH
2006-09-26  5:37                                                           ` [PATCH 30/47] Driver core: create devices/virtual/ tree Greg KH
2006-09-26  5:37                                                             ` [PATCH 31/47] Class: add support for class interfaces for devices Greg KH
2006-09-26  5:37                                                               ` [PATCH 32/47] Driver core: add ability for devices to create and remove bin files Greg KH
2006-09-26  5:37                                                                 ` [PATCH 33/47] kobject: must_check fixes Greg KH
2006-09-26  5:37                                                                   ` [PATCH 34/47] sysfs_remove_bin_file: no return value, dump_stack on error Greg KH
2006-09-26  5:37                                                                     ` [PATCH 35/47] Driver core: fix comments in drivers/base/power/resume.c Greg KH
2006-09-26  5:37                                                                       ` [PATCH 36/47] Driver core: fixed add_bind_files() definition Greg KH
2006-09-26  5:37                                                                         ` [PATCH 37/47] add __must_check to device management code Greg KH
2006-09-26  5:37                                                                           ` [PATCH 38/47] add CONFIG_ENABLE_MUST_CHECK Greg KH
2006-09-26  5:37                                                                             ` [PATCH 39/47] v4l-dev2: handle __must_check Greg KH
2006-09-26  5:38                                                                               ` [PATCH 40/47] drivers/base: Platform notify needs to occur before drivers attach to the device Greg KH
2006-09-26  5:38                                                                                 ` [PATCH 41/47] drivers/base: check errors Greg KH
2006-09-26  5:38                                                                                   ` [PATCH 42/47] sysfs: add proper sysfs_init() prototype Greg KH
2006-09-26  5:38                                                                                     ` [PATCH 43/47] Driver Core: add ability for drivers to do a threaded probe Greg KH
2006-09-26  5:38                                                                                       ` [PATCH 44/47] PCI: enable driver multi-threaded probe Greg KH
2006-09-26  5:38                                                                                         ` [PATCH 45/47] Driver core: Fix potential deadlock in driver core Greg KH
2006-09-26  5:38                                                                                           ` [PATCH 46/47] Driver core: Remove unneeded routines from " Greg KH
2006-09-26  5:38                                                                                             ` [PATCH 47/47] Driver core: Don't call put methods while holding a spinlock Greg KH
2006-09-27 18:51                                                                                         ` [PATCH 44/47] PCI: enable driver multi-threaded probe Olaf Hering
2006-09-29 23:32                                                                                           ` Greg KH
2006-09-30  6:07                                                                                             ` Olaf Hering
2006-09-26 17:23                                                                                   ` [PATCH 41/47] drivers/base: check errors Dmitry Torokhov
2006-09-27  4:33                                                                                     ` Greg KH
2006-09-26 13:24                                                             ` [PATCH 30/47] Driver core: create devices/virtual/ tree Dmitry Torokhov
2006-09-26 13:41                                                               ` Greg KH
2006-09-26 13:51                                                                 ` Dmitry Torokhov
2006-09-26 14:26                                                                   ` Greg KH
2006-09-26 17:15                                                                     ` Dmitry Torokhov
2006-09-26 13:20                                                     ` [PATCH 26/47] Driver core: add groups support to struct device Dmitry Torokhov
2006-09-26 13:46                                                       ` Greg KH
2006-09-26 14:01                                                         ` Dmitry Torokhov
2006-09-26 14:23                                                           ` Greg KH
2006-09-26 17:10                                                             ` Dmitry Torokhov
2006-09-27 14:40                                                             ` Pavel Machek
2006-09-26 15:18                                                         ` Marcel Holtmann
2006-09-26 12:34 ` [GIT PATCH] Driver Core patches for 2.6.18 Mike Galbraith
2006-09-26 20:39   ` Greg KH
2006-09-27  8:47     ` Mike Galbraith
2006-09-27  6:58       ` Rafael J. Wysocki
2006-09-27 10:48         ` Mike Galbraith
2006-09-27 13:03           ` Mike Galbraith
2006-09-27 11:42             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11592491371254-git-send-email-greg@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox