Re: [PATCH 26/47] Driver core: add groups support to struct device

Dmitry Torokhov
2006-09-26T13:20:20Z

On 9/26/06, Greg KH <greg@kroah.com> wrote:
> From: Greg Kroah-Hartman <gregkh@suse.de>
>
> This is needed for the network class devices in order to be able to
> convert over to use struct device.
>

Greg,

You keep pushing out patches that merge class devices and standard
devices but you still have not shown the usefullness of this process.
Why do you feel the need to change internal kernel structures
(ever-expanding struct device to accomodate everything that is in
struct class_device) when it should be possible to simply adjust sysfs
representation of the kernel tree (moving class devices into
/sys/device/.. part of the tree) to udev's liking and leave the rest
of the kernel alone. You have seen the patch, only minor changes in
driver/base/class.c are needed to accomplish the move.

I really disappointed that there was no discussion/review of the
implementation at all.

--
Dmitry