Re: [PATCH 41/47] drivers/base: check errors

Greg KH
2006-09-27T04:40:35Z

On Tue, Sep 26, 2006 at 01:23:34PM -0400, Dmitry Torokhov wrote:
> On 9/26/06, Greg KH <greg@kroah.com> wrote:
> >From: Andrew Morton <akpm@osdl.org>
> >
> >Add lots of return-value checking.
> >
> >+ if (error)
> >+ goto out;
> >+ error = sysfs_create_link(&bus->devices.kobj,
> >+ &dev->kobj, dev->bus_id);
> >+ if (error)
> >+ goto out;
> >+ error = sysfs_create_link(&dev->kobj,
> >+ &dev->bus->subsys.kset.kobj, "subsystem");
> >+ if (error)
> >+ goto out;
> >+ error = sysfs_create_link(&dev->kobj,
> >+ &dev->bus->subsys.kset.kobj, "bus");
> > }
> >+out:
> > return error;
>
> What about removing the links that were created if one of these calls fails?

Yes, that would be good, I think I have a patch in my queue that handles
that properly...

thanks,

greg k-h