Re: [PATCH 26/47] Driver core: add groups support to struct device

Pavel Machek
2006-09-27T19:25:58Z

Hi!

> > Why can't the device itself manage it? If you want to stub out the
> > common parts just create a function like netdev_suspend and call it at
> > appropriate time.
>
> Because you would then need to add that function call to _every_ network
> device driver. This way, we do not need to do that as the class gets
> called in the proper place before the device driver does.

I'm not sure this is good idea, it also has potential to break all the
network devices with one diff.

Some devices will be doing parts of class_suspend already, so I do not
think that some breakage will happen.

--
Thanks for all the (sleeping) penguins.