From: Marcel Holtmann <marcel@holtmann.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nomzomi: remove bogus cast
Date: Tue, 26 Sep 2006 09:59:32 +0200 [thread overview]
Message-ID: <1159257572.1235.1.camel@localhost> (raw)
In-Reply-To: <1159223925.11049.160.camel@localhost.localdomain>
Hi Alan,
> May as well go straight into the main tree
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c linux-2.6.18-mm1/drivers/char/nozomi.c
> --- linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:10:08.000000000 +0100
> +++ linux-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:17:53.000000000 +0100
> @@ -1225,7 +1225,7 @@
> }
>
> if ( !(dc = get_dc_by_pdev(dev_id)) ) {
> - ERR("Could not find device context from pci_dev: %d", (u32) dev_id);
> + ERR("Could not find device context from pci_dev: %p", dev_id);
> return IRQ_NONE;
> }
>
this driver needs more love than this ;)
Regards
Marcel
prev parent reply other threads:[~2006-09-26 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 22:38 [PATCH] nomzomi: remove bogus cast Alan Cox
2006-09-25 22:55 ` Linus Torvalds
2006-09-26 7:59 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159257572.1235.1.camel@localhost \
--to=marcel@holtmann.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox