* [PATCH] nomzomi: remove bogus cast
@ 2006-09-25 22:38 Alan Cox
2006-09-25 22:55 ` Linus Torvalds
2006-09-26 7:59 ` Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Alan Cox @ 2006-09-25 22:38 UTC (permalink / raw)
To: torvalds, linux-kernel
May as well go straight into the main tree
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c linux-2.6.18-mm1/drivers/char/nozomi.c
--- linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:10:08.000000000 +0100
+++ linux-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:17:53.000000000 +0100
@@ -1225,7 +1225,7 @@
}
if ( !(dc = get_dc_by_pdev(dev_id)) ) {
- ERR("Could not find device context from pci_dev: %d", (u32) dev_id);
+ ERR("Could not find device context from pci_dev: %p", dev_id);
return IRQ_NONE;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nomzomi: remove bogus cast
2006-09-25 22:38 [PATCH] nomzomi: remove bogus cast Alan Cox
@ 2006-09-25 22:55 ` Linus Torvalds
2006-09-26 7:59 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2006-09-25 22:55 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel
On Mon, 25 Sep 2006, Alan Cox wrote:
>
> May as well go straight into the main tree
Umm.
Great idea, but that file is not actually _in_ the main tree yet. I think
your original patch to add it still lies in the -mm queue ;)
So send it to Andrew, or just re-send it once Andrew has patch-bombed me,
ok? I'm too disorganized to keep track of it separately..
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nomzomi: remove bogus cast
2006-09-25 22:38 [PATCH] nomzomi: remove bogus cast Alan Cox
2006-09-25 22:55 ` Linus Torvalds
@ 2006-09-26 7:59 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2006-09-26 7:59 UTC (permalink / raw)
To: Alan Cox; +Cc: torvalds, linux-kernel
Hi Alan,
> May as well go straight into the main tree
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c linux-2.6.18-mm1/drivers/char/nozomi.c
> --- linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:10:08.000000000 +0100
> +++ linux-2.6.18-mm1/drivers/char/nozomi.c 2006-09-25 12:17:53.000000000 +0100
> @@ -1225,7 +1225,7 @@
> }
>
> if ( !(dc = get_dc_by_pdev(dev_id)) ) {
> - ERR("Could not find device context from pci_dev: %d", (u32) dev_id);
> + ERR("Could not find device context from pci_dev: %p", dev_id);
> return IRQ_NONE;
> }
>
this driver needs more love than this ;)
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-26 7:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-25 22:38 [PATCH] nomzomi: remove bogus cast Alan Cox
2006-09-25 22:55 ` Linus Torvalds
2006-09-26 7:59 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox