From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: tom@opengridcomputing.com
Subject: [Patch] Possible dereference in drivers/infiniband/hw/amso1100/c2_cm.c
Date: Tue, 26 Sep 2006 12:40:28 +0200 [thread overview]
Message-ID: <1159267228.5491.2.camel@alice> (raw)
hi,
another dereference spotted by the coverity checker (cid #1395)
In case we cant alloc the vq_req, we goto bail1, where we
call vq_req_free(c2dev, vq_req); which then dereferences vq_req().
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.18-git5/drivers/infiniband/hw/amso1100/c2_cm.c.orig 2006-09-26 12:36:56.000000000 +0200
+++ linux-2.6.18-git5/drivers/infiniband/hw/amso1100/c2_cm.c 2006-09-26 12:37:19.000000000 +0200
@@ -302,7 +302,7 @@ int c2_llp_accept(struct iw_cm_id *cm_id
vq_req = vq_req_alloc(c2dev);
if (!vq_req) {
err = -ENOMEM;
- goto bail1;
+ goto bail0;
}
vq_req->qp = qp;
vq_req->cm_id = cm_id;
reply other threads:[~2006-09-26 10:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159267228.5491.2.camel@alice \
--to=snakebyte@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox