public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Olivier Galibert <galibert@pobox.com>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata-sff: use our IRQ defines
Date: Tue, 26 Sep 2006 22:19:22 +0100	[thread overview]
Message-ID: <1159305562.11049.312.camel@localhost.localdomain> (raw)
In-Reply-To: <20060926204433.GA77171@dspnet.fr.eu.org>

Ar Maw, 2006-09-26 am 22:44 +0200, ysgrifennodd Olivier Galibert:
> >  		if (probe_ent->irq)
> > -			probe_ent->irq2 = 15;
> > +			probe_ent->irq2 = ATA_SECONDARY_IRQ;
> >  		else
> >  			probe_ent->irq = 15;
> 
> Isn't that one supposed to be ATA_SECONDARY_IRQ too?
> 
> >  		probe_ent->port[1].cmd_addr = ATA_SECONDARY_CMD;

Duh yes...

(adds another paper bag to the pile)


  reply	other threads:[~2006-09-26 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-26 16:55 [PATCH] libata-sff: use our IRQ defines Alan Cox
2006-09-26 17:35 ` Jeff Garzik
2006-09-26 20:44 ` Olivier Galibert
2006-09-26 21:19   ` Alan Cox [this message]
2006-09-26 21:25     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159305562.11049.312.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=galibert@pobox.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox