From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: eiichiro.oiwa.nm@hitachi.com
Cc: Jesse Barnes <jesse.barnes@intel.com>,
akpm@osdl.org, tony.luck@intel.com, greg@kroah.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel for embedded VGA
Date: Wed, 27 Sep 2006 13:12:15 +0100 [thread overview]
Message-ID: <1159359135.11049.341.camel@localhost.localdomain> (raw)
In-Reply-To: <XNM1$9$0$4$$3$3$7$A$9002684U451a5f21@hitachi.com>
Ar Mer, 2006-09-27 am 20:23 +0900, ysgrifennodd
eiichiro.oiwa.nm@hitachi.com:
> I moved pci_fixup_video to generic location (driver/pci/quirks.c).
> I tested generic fixup_video on x86, x86_64 and IA64, and confirmed
> we can read Video BIOS from the sysfs rom with embedded VGA.
Lots of embedded systems don't have a PCI bios in the usual sense, and
cannot run the x86 code in the ROM firmware either. That doesn't appear
to be a big problem when setting PCI_ROM_SHADOW but those platforms may
not all be able to access the shadow rom if one exists.
Can you fix the comment in drivers/pci/rom.c to reflect the changes.
Otherwise looks good.
Alan
next prev parent reply other threads:[~2006-09-27 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 11:23 [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel for embedded VGA eiichiro.oiwa.nm
2006-09-27 12:12 ` Alan Cox [this message]
2006-09-28 5:03 ` Re[2]: [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel forembedded VGA eiichiro.oiwa.nm
-- strict thread matches above, loose matches on Subject: below --
2006-09-26 7:42 [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel for embedded VGA eiichiro.oiwa.nm
2006-09-26 15:09 ` Bjorn Helgaas
2006-09-26 15:48 ` Jesse Barnes
2006-09-26 15:50 ` Jesse Barnes
[not found] <200609260605.k8Q65dAc005670@fire-2.osdl.org>
2006-09-26 7:35 ` eiichiro.oiwa.nm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159359135.11049.341.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=eiichiro.oiwa.nm@hitachi.com \
--cc=greg@kroah.com \
--cc=jesse.barnes@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox