From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: a.zummo@towertech.it
Subject: [Patch] Remove unnecessary check in drivers/rtc/rtc-v3020.c
Date: Thu, 28 Sep 2006 00:49:36 +0200 [thread overview]
Message-ID: <1159397376.14069.5.camel@alice> (raw)
hi,
looks like the probe function always gets a valid pdev,
and checking it after dereferencing it is pretty useless.
This patch removes the check (cid #1365)
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.18-git7/drivers/rtc/rtc-v3020.c.orig 2006-09-27 22:18:37.000000000 +0200
+++ linux-2.6.18-git7/drivers/rtc/rtc-v3020.c 2006-09-27 22:18:50.000000000 +0200
@@ -169,9 +169,6 @@ static int rtc_probe(struct platform_dev
if (pdev->resource[0].flags != IORESOURCE_MEM)
return -EBUSY;
- if (pdev == NULL)
- return -EBUSY;
-
chip = kzalloc(sizeof *chip, GFP_KERNEL);
if (!chip)
return -ENOMEM;
reply other threads:[~2006-09-27 22:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159397376.14069.5.camel@alice \
--to=snakebyte@gmx.de \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox